mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] remove redundant .gitignore entries
@ 2010-12-13  6:00 Baruch Siach
  2010-12-13 12:08 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2010-12-13  6:00 UTC (permalink / raw)
  To: barebox

The ARCH and CROSS_COMPILE entries were introduced in commit cdfd8bdd, probably
by mistake.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .gitignore |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 6f04601..cdc4df0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -34,8 +34,6 @@ barebox.netx
 barebox.map
 System.map
 Module.symvers
-ARCH
-CROSS_COMPILE
 barebox_default_env
 
 #
-- 
1.7.2.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove redundant .gitignore entries
  2010-12-13  6:00 [PATCH] remove redundant .gitignore entries Baruch Siach
@ 2010-12-13 12:08 ` Sascha Hauer
  2010-12-13 12:33   ` Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2010-12-13 12:08 UTC (permalink / raw)
  To: Baruch Siach; +Cc: barebox

Hi Baruch,

On Mon, Dec 13, 2010 at 08:00:10AM +0200, Baruch Siach wrote:
> The ARCH and CROSS_COMPILE entries were introduced in commit cdfd8bdd, probably
> by mistake.

'redundant' seems to imply that these are duplicates, but they are not.
They were also not introduced by accident. I use a wrapper script for
make which evaluates these files, so I'd like to keep them, although
they are only for my personal use.

Sascha

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .gitignore |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 6f04601..cdc4df0 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -34,8 +34,6 @@ barebox.netx
>  barebox.map
>  System.map
>  Module.symvers
> -ARCH
> -CROSS_COMPILE
>  barebox_default_env
>  
>  #
> -- 
> 1.7.2.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove redundant .gitignore entries
  2010-12-13 12:08 ` Sascha Hauer
@ 2010-12-13 12:33   ` Baruch Siach
  2010-12-13 13:10     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2010-12-13 12:33 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Hi Sascha,

On Mon, Dec 13, 2010 at 01:08:57PM +0100, Sascha Hauer wrote:
> On Mon, Dec 13, 2010 at 08:00:10AM +0200, Baruch Siach wrote:
> > The ARCH and CROSS_COMPILE entries were introduced in commit cdfd8bdd, probably
> > by mistake.
> 
> 'redundant' seems to imply that these are duplicates, but they are not.

English is not my native language. I couldn't come up with anything better.

> They were also not introduced by accident. I use a wrapper script for
> make which evaluates these files, so I'd like to keep them, although
> they are only for my personal use.

The .git/info/exclude file is a better place for local excludes, IMHO. I use 
it myself for this.

baruch

> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .gitignore |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 6f04601..cdc4df0 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -34,8 +34,6 @@ barebox.netx
> >  barebox.map
> >  System.map
> >  Module.symvers
> > -ARCH
> > -CROSS_COMPILE
> >  barebox_default_env
> >  
> >  #
> > -- 
> > 1.7.2.3

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove redundant .gitignore entries
  2010-12-13 12:33   ` Baruch Siach
@ 2010-12-13 13:10     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2010-12-13 13:10 UTC (permalink / raw)
  To: Baruch Siach; +Cc: barebox

On Mon, Dec 13, 2010 at 02:33:28PM +0200, Baruch Siach wrote:
> Hi Sascha,
> 
> On Mon, Dec 13, 2010 at 01:08:57PM +0100, Sascha Hauer wrote:
> > On Mon, Dec 13, 2010 at 08:00:10AM +0200, Baruch Siach wrote:
> > > The ARCH and CROSS_COMPILE entries were introduced in commit cdfd8bdd, probably
> > > by mistake.
> > 
> > 'redundant' seems to imply that these are duplicates, but they are not.
> 
> English is not my native language. I couldn't come up with anything better.
> 
> > They were also not introduced by accident. I use a wrapper script for
> > make which evaluates these files, so I'd like to keep them, although
> > they are only for my personal use.
> 
> The .git/info/exclude file is a better place for local excludes, IMHO. I use 
> it myself for this.

Ok, works good. I applied your patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-12-13 13:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-13  6:00 [PATCH] remove redundant .gitignore entries Baruch Siach
2010-12-13 12:08 ` Sascha Hauer
2010-12-13 12:33   ` Baruch Siach
2010-12-13 13:10     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox