Re: [PATCH] (reformated) Allow board specific fancy banner

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 22:40 Sun 26 Dec     , Franck JULLIEN wrote:
> This time I used git to send the email. I think I get it right.
> However, I didn't find how to put this file in the thread we were later...
> I don't think it is possible since those emails didn't have ID's to use with
> the In-Reply-To option (right ?).
> 
> ---
>  common/Kconfig   |    6 ++++++
>  common/console.c |   10 ++++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 617f640..d46c8fc 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
>  	  Allow to set PS1 from the command line. PS1 can have several escaped commands
>  	  like \h for CONFIG_BOARDINFO or \w for the current working directory.
>  
> +config BOARD_BANNER
> +	bool
> +	prompt "allow a board specific fancy banner"
> +	help
> +	  Allow to define a custom board banner (you must define BOARD_BANNER in your config.h)
> +
>  config HUSH_GETOPT
>  	bool
>  	depends on SHELL_HUSH
> diff --git a/common/console.c b/common/console.c
> index 82786f2..8a830e3 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -46,7 +46,17 @@ EXPORT_SYMBOL(console_list);
>  static void display_banner (void)
>  {
>  	printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
> +#ifdef CONFIG_BOARD_BANNER
> +#ifdef BOARD_BANNER
> +	printf(RELOC(BOARD_BANNER));
> +#else
> +#define VT100_YELLOW	"\033[1;33m"
> +#define VT100_RESET	"\033[1;0m"
> +	printf(RELOC("Board: " VT100_YELLOW CONFIG_BOARDINFO VT100_RESET "\n"));
why not define it in the Kconfig simply?

I'm sorry but I do not see why we can not do it in the defconfig

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox