Re: [PATCH] (reformated) Allow board specific fancy banner

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

>      > diff --git a/common/console.c b/common/console.c
>      > index 82786f2..8a830e3 100644
>      > --- a/common/console.c
>      > +++ b/common/console.c
>      > @@ -46,7 +46,17 @@ EXPORT_SYMBOL(console_list);
>      >  static void display_banner (void)
>      >  {
>      >       printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
>      > +#ifdef CONFIG_BOARD_BANNER
>      > +#ifdef BOARD_BANNER
>      > +     printf(RELOC(BOARD_BANNER));
>      > +#else
>      > +#define VT100_YELLOW "\033[1;33m"
>      > +#define VT100_RESET  "\033[1;0m"
>      > +     printf(RELOC("Board: " VT100_YELLOW CONFIG_BOARDINFO VT100_RESET
>      "\n"));
>      why not define it in the Kconfig simply?
> 
>      I'm sorry but I do not see why we can not do it in the defconfig
> 
>      Best Regards,
>      J.
> 
>    We could do it in the arch/_the_arch_/Kconfig with depends on _your_board_
>    but I don't think that the better/more generic way. Moreover, if we ask
>    for the banner in Kconfig (with a string entry), fancy escape code and/or
>    carriage return will be hard to enter manually.
>    This is for example what I use for my neek board:
>    #define BOARD_BANNER "\e[1;32m\
>    ****************************************\n\
>    *          Altera NEEK board           *\n\
>    ****************************************\
>    \e[0m\n\n"
>    However, if you want I could manage to use the Kconfig way.....
>    Best regards,
so define completely the banner in the config.h
no VT100.... in the console.c as diferrent boards will have different colour

and something like this will be better 

#ifndef CONFIG_BOARD_BANNER
#undef  CONFIG_BOARD_BANNER_TEXT
#define CONFIG_BOARD_BANNER_TEXT "Board: " CONFIG_BOARDINFO "\n"
#endif

printf(RELOC(CONFIG_BOARD_BANNER_TEXT));

please keep CONFIG_xxxx for the macro even in the config.h

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox