From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Add an option to set a board specific banner
Date: Tue, 4 Jan 2011 10:00:15 +0100 [thread overview]
Message-ID: <20110104090015.GB11295@pengutronix.de> (raw)
In-Reply-To: <87wrmlbl2w.fsf@macbook.be.48ers.dk>
On Tue, Jan 04, 2011 at 12:53:43AM +0100, Peter Korsgaard wrote:
> >>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> Sascha> Ok, I can see your problem. I think we should rather define a
> Sascha> board specific function to display a banner than a string, so
> Sascha> something like:
>
> Sascha> config BOARD_BANNER
> Sascha> bool
>
> Sascha> #ifdef CONFIG_BOARD_BANNER
> Sascha> display_board_banner();
> Sascha> #else
> Sascha> printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> Sascha> #endif
>
> Even better, stick:
>
> #ifdef CONFIG_BOARD_BANNER
> extern void display_board_banner(void);
> #else
> static inline void display_board_banner(void)
> {
> printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> }
> #endif
>
The printing of version_string is missing. We could add it to
display_board_banner, but I really would like to keep this in a
generic place to make sure barebox is recognizable by both users
and automatic scripts. Or does anybody wants to fully customize
the initial output of barebox?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-01-04 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101230034811.GS19266@game.jcrosoft.org>
2010-12-30 12:49 ` Franck JULLIEN
2010-12-31 7:24 ` Jean-Christophe PLAGNIOL-VILLARD
2011-01-03 11:41 ` Sascha Hauer
2011-01-03 12:45 ` Franck JULLIEN
2011-01-03 13:50 ` Sascha Hauer
2011-01-03 19:42 ` Franck JULLIEN
2011-01-03 23:53 ` Peter Korsgaard
2011-01-04 9:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104090015.GB11295@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jacmet@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox