From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org>
Received: from 26.mail-out.ovh.net ([91.121.27.225])
	by canuck.infradead.org with smtp (Exim 4.72 #1 (Red Hat Linux))
	id 1PbFXI-0000V1-Og
	for barebox@lists.infradead.org; Fri, 07 Jan 2011 16:51:34 +0000
Date: Fri, 7 Jan 2011 17:51:28 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Message-ID: <20110107165128.GA15365@game.jcrosoft.org>
References: <1294389316-6569-1-git-send-email-jbe@pengutronix.de>
	<1294389316-6569-10-git-send-email-jbe@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1294389316-6569-10-git-send-email-jbe@pengutronix.de>
List-Id: <barebox.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/barebox>,
	<mailto:barebox-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/barebox/>
List-Post: <mailto:barebox@lists.infradead.org>
List-Help: <mailto:barebox-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/barebox>,
	<mailto:barebox-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: barebox-bounces@lists.infradead.org
Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org
Subject: Re: [PATCH 09/10] LINUX16: Add selection of the VESA video mode
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org

>  		}
>  	}
>  
> @@ -227,6 +243,14 @@ static int do_linux16(struct command *cmdtp, int argc, char *argv[])
>  		goto on_error;
>  	}
>  
> +	/*
> +	 * The kernel does not check for the "vga=<val>" kernel command line
> +	 * parameter anymore. It expects this kind of information in the
> +	 * boot parameters instead.
> +	 */
> +	if (vid_mode != NORMAL_VGA)
> +		lh->vid_mode = vid_mode;
> +
>  	/* If SETUP_SECTS is not set, set it to the default.  */
>  	if (setup_sects == 0) {
>  		printf("Fixing setup sector count\n");
> @@ -297,8 +321,9 @@ on_error:
>  }
>  
>  BAREBOX_CMD_HELP_START(linux16)
> -BAREBOX_CMD_HELP_USAGE("linux16 <file>\n")
> -BAREBOX_CMD_HELP_SHORT("Boot a kernel on x86 via real mode code.\n")
> +BAREBOX_CMD_HELP_USAGE("linux16 <file> [-v <mode>]\n")
> +BAREBOX_CMD_HELP_SHORT("Boot a kernel <file> on x86 via real mode code.\n")
> +BAREBOX_CMD_HELP_OPT  ("-v <mode>",   "VESA video mode number or 'ask'\n")
>  BAREBOX_CMD_HELP_END
>  
>  /**
> @@ -307,6 +332,10 @@ BAREBOX_CMD_HELP_END
>  <p> Only kernel images in bzImage format are supported by now. See \ref
>  x86_boot_preparation for more info about how to use this command.</p>
>  
> +<p> For the video mode refer the Linux kernel documentation
> +'Documentation/fb/vesafb.txt' for correct VESA mode numbers. If the keyword
> +'ask' instead of a number is given, the starting kernel will ask for a number.
missing </p>?

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox