From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org,
Patrice Vilchez <patrice.vilchez@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH] at91sam9m10g45ek: add board revision support
Date: Sat, 15 Jan 2011 17:21:34 +0100 [thread overview]
Message-ID: <20110115162134.GH9041@pengutronix.de> (raw)
In-Reply-To: <20110115155035.GD14798@game.jcrosoft.org>
On Sat, Jan 15, 2011 at 04:50:35PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> > > index e5bd45e..4d35ebe 100644
> > > --- a/arch/arm/mach-at91/Kconfig
> > > +++ b/arch/arm/mach-at91/Kconfig
> > > @@ -174,7 +174,8 @@ config MACH_AT91SAM9M10G45EK
> > > bool "Atmel AT91SAM9M10G45-EK Evaluation Kit"
> > > select HAVE_NAND_ATMEL_BUSWIDTH_16
> > > help
> > > - Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit.
> > > + Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit
> > > + or AT91SAM9G45-EKES or AT91SAM9M10-EKES (for those 2 select the LG LCD)
> > > <http://atmel.com/dyn/products/tools_card_v2.asp?tool_id=4735>
> >
> > Isn't it better to let the user choose the exact board type here and
> > select the display type automatically depending on the choice?
> They are nearly the same board and the idea is to allow to specify the lcd as
> we can change it and it's the only difference between the 3 boards,
Ok, fine. Note I didn't want to suggest a complete new board support,
only the Kconfig option. The user likely knows better which board he has
than what exact display is connected to it.
Can you then add a help text to the display choice? Something like:
+choice
+ prompt "LCD type"
+ depends on MACH_AT91SAM9M10G45EK
+
+config LCD_TRULY_TFT1N4633E
+ bool "truly TFT1N4633E"
+ help
+ Found on AT91SAM9M10G45-EK
+
+config LCD_LG_LB043WQ1
+ bool "LG philips LB043WQ1"
+ help
+ Found on AT91SAM9G45-EKES and AT91SAM9M10-EKES
+
+endchoice
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-01-15 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 2:25 Jean-Christophe PLAGNIOL-VILLARD
2011-01-15 15:25 ` Sascha Hauer
2011-01-15 15:50 ` Jean-Christophe PLAGNIOL-VILLARD
2011-01-15 16:21 ` Sascha Hauer [this message]
2011-01-22 15:45 ` [PATCH v2] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115162134.GH9041@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox