From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org>
Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33])
	by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux))
	id 1Pempf-0001DM-EB
	for barebox@lists.infradead.org; Mon, 17 Jan 2011 11:01:08 +0000
From: Juergen Beisert <jbe@pengutronix.de>
Date: Mon, 17 Jan 2011 11:59:31 +0100
References: <1295259766-19301-1-git-send-email-s.hauer@pengutronix.de>
	<1295259766-19301-4-git-send-email-s.hauer@pengutronix.de>
In-Reply-To: <1295259766-19301-4-git-send-email-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201101171159.31154.jbe@pengutronix.de>
List-Id: <barebox.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/barebox>,
	<mailto:barebox-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/barebox/>
List-Post: <mailto:barebox@lists.infradead.org>
List-Help: <mailto:barebox-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/barebox>,
	<mailto:barebox-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: barebox-bounces@lists.infradead.org
Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM i.MX28 tx28: use a fixed framebuffer address
To: barebox@lists.infradead.org

Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/boards/karo-tx28/tx28-stk5.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boards/karo-tx28/tx28-stk5.c
> b/arch/arm/boards/karo-tx28/tx28-stk5.c index 6de41f7..adad8b9 100644
> --- a/arch/arm/boards/karo-tx28/tx28-stk5.c
> +++ b/arch/arm/boards/karo-tx28/tx28-stk5.c
> @@ -19,11 +19,13 @@
>  #include <errno.h>
>  #include <mci.h>
>  #include <fec.h>
> +#include <sizes.h>
>  #include <asm/io.h>
>  #include <mach/imx-regs.h>
>  #include <mach/clock.h>
>  #include <mach/mci.h>
>  #include <mach/fb.h>
> +#include <asm/sections.h>
>
>  static struct stm_mci_platform_data mci_pdata = {
>  	.caps = MMC_MODE_4BIT | MMC_MODE_HS | MMC_MODE_HS_52MHz,
> @@ -181,11 +183,15 @@ static struct fb_videomode tx28evk_vmodes[] = {
>  	},
>  };
>
> +#define MAX_FB_SIZE SZ_2M
> +
>  static struct imx_fb_videomode imxfb_mode = {
>  	.mode_list = tx28evk_vmodes,
>  	.mode_cnt = ARRAY_SIZE(tx28evk_vmodes),
>  	.dotclk_delay = 0,	/* no adaption required */
>  	.ld_intf_width = STMLCDIF_24BIT,	/* full 24 bit */
> +	.fixed_screen = (void *)(0x40000000 + SZ_128M - MAX_FB_SIZE),
> +	.fixed_screen_size = MAX_FB_SIZE,
>  };

Question only: Any idea how we could make this setup (base address and size of 
the fixed screen) a runtime feature? This would be a nice feature like most 
modern BIOS also have: Make the size of the video memory shared with the CPU 
selectable at runtime.

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox