mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: scripts
Date: Tue, 1 Mar 2011 16:20:25 +0200	[thread overview]
Message-ID: <20110301142024.GB13983@jasper.tkos.co.il> (raw)
In-Reply-To: <4D6CFE93.40508@pengutronix.de>

Hi Marc,

On Tue, Mar 01, 2011 at 03:11:31PM +0100, Marc Kleine-Budde wrote:
> On 03/01/2011 03:06 PM, Vanalme Filip wrote:
> [...]
> 
> > One more question about barebox scripts (I guess even scripts in
> > general...). This is part of a script from another board (that I took
> > over for my own board):
> 
> > #!/bin/sh
> > 
> > . /env/config
> > 
> > If [ x$1 = xflash ]; then
> > 	root=flash
> > 	kernel=flash
> > fi
> > 
> > if [ x$1 = xnet ]; then
> > 	root=net
> > 	kernel=net
> > fi
> > 
> > why the scripts are using i.e. [ x$1 = xflash ] instead of just simply [ $1 = flash ] ? Both are doing the same, no ?
> 
> The shell is quite old and doesn't support that. But you're right for
> modern shells like bash or dash.

I get this under bash:

$ [ $UNDEF = test ]
bash: [: =: unary operator expected

However '[ "$UNDEF" = test ]' behaves as expected under bash (but not under 
hush, which is the shell of Barebox).

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-03-01 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 16:03 scripts Vanalme Filip
2011-02-28 16:09 ` scripts Marc Kleine-Budde
2011-02-28 16:12   ` scripts Marc Kleine-Budde
2011-03-01  8:02     ` scripts Vanalme Filip
2011-03-01 14:06       ` scripts Vanalme Filip
2011-03-01 14:11         ` scripts Marc Kleine-Budde
2011-03-01 14:20           ` Baruch Siach [this message]
2011-03-02 16:14             ` scripts Uwe Kleine-König
2011-03-02  8:36           ` scripts Vanalme Filip
2011-03-02  9:30             ` scripts Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110301142024.GB13983@jasper.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=barebox@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox