mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] Add Nios2 generic board support
Date: Wed, 16 Mar 2011 10:39:16 +0100	[thread overview]
Message-ID: <20110316093916.GP29521@pengutronix.de> (raw)
In-Reply-To: <1299710787-11990-3-git-send-email-franck.jullien@gmail.com>

Hi Julien,

On Wed, Mar 09, 2011 at 11:46:27PM +0100, Franck JULLIEN wrote:
> ---
>  nios2/boards/generic/Makefile      |    2 +
>  nios2/boards/generic/barebox.lds.S |  126 +++++++++++
>  nios2/boards/generic/config.h      |   64 ++++++
>  nios2/boards/generic/env/config    |   20 ++
>  nios2/boards/generic/generic.c     |   74 +++++++
>  nios2/boards/generic/nios_sopc.h   |  406 ++++++++++++++++++++++++++++++++++++
>  6 files changed, 692 insertions(+), 0 deletions(-)
>  create mode 100644 nios2/boards/generic/Makefile
>  create mode 100644 nios2/boards/generic/barebox.lds.S
>  create mode 100644 nios2/boards/generic/config.h
>  create mode 100644 nios2/boards/generic/env/config
>  create mode 100644 nios2/boards/generic/generic.c
>  create mode 100644 nios2/boards/generic/nios_sopc.h
> 
> diff --git a/nios2/boards/generic/Makefile b/nios2/boards/generic/Makefile
> new file mode 100644
> index 0000000..28dd481
> --- /dev/null
> +++ b/nios2/boards/generic/Makefile
> @@ -0,0 +1,2 @@
> +obj-y += generic.o
> +extra-y += barebox.lds
> diff --git a/nios2/boards/generic/barebox.lds.S b/nios2/boards/generic/barebox.lds.S

This linker script looks fairly generic. Can we start with a generic
nios2 linker script instead of adding it to the board?

> diff --git a/nios2/boards/generic/env/config b/nios2/boards/generic/env/config
> new file mode 100644
> index 0000000..3ba4eb4
> --- /dev/null
> +++ b/nios2/boards/generic/env/config
> @@ -0,0 +1,20 @@
> +#!/bin/sh
> +
> +# can be either 'net' or 'flash'
> +kernel=flash
> +root=flash
> +
> +# use 'dhcp' todo dhcp in barebox and in kernel
> +ip=none
> +
> +eth0.ipaddr=192.168.1.69
> +eth0.netmask=255.255.255.0
> +eth0.gateway=192.168.0.1
> +eth0.serverip=192.168.1.117
> +eth0.ethaddr=00:50:C0:C8:10:12

You shouldn't add any ip or MAC addresses to the default environment.
You (or someone else) will end up with funny network errors if you
do.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2011-03-16  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 22:46 Franck JULLIEN
2011-03-16  9:39 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316093916.GP29521@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=franck.jullien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox