From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] [v2] Nios2: Add Altera TSE MAC driver
Date: Mon, 11 Apr 2011 04:37:02 +0200 [thread overview]
Message-ID: <20110411023702.GA18925@game.jcrosoft.org> (raw)
In-Reply-To: <BANLkTi=D=yLy3iZ2ZQuVAwb3Q=UPnk0ZaA@mail.gmail.com>
On 20:21 Sun 10 Apr , Franck JULLIEN wrote:
> 2011/4/10 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> > > index 0000000..2687377
> > > --- /dev/null
> > > +
> > > +static int tse_get_ethaddr(struct eth_device *edev, unsigned
> char *m)
> > > +{
> > > + /* There is no eeprom */
> > so return the content of the register no?
> >
> > Well, the register is reseted to 0 when the MAC starts so there is
> no
> > Ethernet address
> > to get.
> >
> except this function is supposed to return the mac address of the device
> at
> any time so after a set of it it will not be true any more
>
> If I implement the function I get a "eth@eth0: got MAC address from
> EEPROM: 00:00:00:00:00:00" at startup.
> That why I returned -1 as what I could find int at91_ether.c......
> Or, I could find something to return -1 as long as the MAC address hasn't
> been set.
>
I known this issue I re-write recently the at91_ether and the same on macb
will post the patch soon
It's fine the uperlayer will see that it's not a valid mac so this will
generate a random one
cf net/net.c IIRC
Best Regads,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-04-11 2:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 14:08 franck.jullien
2011-04-09 14:08 ` franck.jullien
2011-04-10 4:06 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-10 7:13 ` Franck JULLIEN
2011-04-10 10:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-10 18:21 ` Franck JULLIEN
2011-04-11 2:37 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-04-11 7:23 ` Franck JULLIEN
2011-04-11 7:47 ` Sascha Hauer
2011-04-11 7:52 ` Franck JULLIEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411023702.GA18925@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox