From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Q9Zhk-0006DO-6o for barebox@lists.infradead.org; Tue, 12 Apr 2011 09:16:13 +0000 Date: Tue, 12 Apr 2011 11:16:09 +0200 From: Sascha Hauer Message-ID: <20110412091609.GM7285@pengutronix.de> References: <1302596272-21635-1-git-send-email-s.hauer@pengutronix.de> <1302596272-21635-3-git-send-email-s.hauer@pengutronix.de> <201104121057.11443.jbe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201104121057.11443.jbe@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/3] mci: turn several pr_* statements into debug To: Juergen Beisert Cc: barebox@lists.infradead.org On Tue, Apr 12, 2011 at 10:57:11AM +0200, Juergen Beisert wrote: > Mostly ACK, but ... > > Sascha Hauer wrote: > > These are mostly useful for developers, so turn them off by default. > > > > Signed-off-by: Sascha Hauer > > --- > > drivers/mci/mci-core.c | 26 +++++++++++++------------- > > 1 files changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c > > index a51c44b..c4c5c2f 100644 > > --- a/drivers/mci/mci-core.c > > +++ b/drivers/mci/mci-core.c > > > > [...] > > > > @@ -1182,7 +1182,7 @@ static int mci_card_probe(struct device_d *mci_dev) > > /* start with a host interface reset */ > > rc = (host->init)(host, mci_dev); > > if (rc) { > > - pr_err("Cannot reset the SD/MMC interface\n"); > > + pr_debug("Cannot reset the SD/MMC interface\n"); > > return rc; > > } Really this shouldn't fail for users. Most of the driver can't fail or print something themselves. > > This is not only useful for the developer. Also for the regular user when > something is broken at runtime. > > > @@ -1192,7 +1192,7 @@ static int mci_card_probe(struct device_d *mci_dev) > > /* reset the card */ > > rc = mci_go_idle(mci_dev); > > if (rc) { > > - pr_warning("Cannot reset the SD/MMC card\n"); > > + pr_debug("Cannot reset the SD/MMC card\n"); > > goto on_error; > > } > > Also useful for the regular user, that tries his shiny new and fresh SD card > and something went wrong at runtime. Ok for this one as it depends on the card inserted. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox