mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: add support to generate uImage
Date: Mon, 25 Apr 2011 13:37:35 +0200	[thread overview]
Message-ID: <20110425113735.GE14770@pengutronix.de> (raw)
In-Reply-To: <1303535118-4737-1-git-send-email-plagnioj@jcrosoft.com>

On Sat, Apr 23, 2011 at 07:05:18AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> so barebox could be loaded as kernel by itself
> 
> add LOAD_TEXT_BASE to specify the load address
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/Makefile |   15 +++++++++++++++
>  common/Kconfig    |    7 +++++++
>  2 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 108bd5e..f0ec667 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -134,6 +134,21 @@ ifeq ($(machine-y),netx)
>  KBUILD_IMAGE := barebox.netx
>  endif
>  
> +MKIMAGE		:= $(objtree)/scripts/mkimage
> +
> +quiet_cmd_uimage = UIMAGE  $@
> +      cmd_uimage = $(MKIMAGE) -A arm -O linux -T kernel \
> +		   -C none -a $(BAREBOX_LOAD) -e $(BAREBOX_ENTRY) \
> +		   -n 'Barebox-$(KERNELRELEASE)' -d $< $@
> +
> +uImage: $(MKIMAGE)
> +uImage: BAREBOX_LOAD=$(CONFIG_LOAD_TEXT_BASE)
> +uImage: BAREBOX_ENTRY=$(CONFIG_TEXT_BASE)
> +
> +uImage: barebox.bin
> +	$(call if_changed,uimage,none)
> +	@echo '  Image $@ is ready'
> +
>  all: $(KBUILD_IMAGE)
>  
>  archprepare: maketools
> diff --git a/common/Kconfig b/common/Kconfig
> index 9e30579..50995d3 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -80,6 +80,13 @@ config TEXT_BASE
>  	help
>  	  The Address barebox gets linked at.
>  
> +config LOAD_TEXT_BASE
> +	prompt "LOAD_TEXT_BASE"
> +	hex
> +	default TEXT_BASE
> +	help
> +	  The Address barebox gets load at as a uImage
> +

No, please don't. When you load barebox with itself you end up
overwriting the running barebox with the just loaded image if using
TEXT_BASE here.
barebox can be started from any address in SDRAM. Isn't there a
mechanism to support this with the uImage format? The U-Boot guys have
the same problem with ARM_PATCH_PHYS_VIRT in the kernel aswell, so I
assume this is already solved in some way, no?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-04-25 11:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-23  5:05 Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 11:37 ` Sascha Hauer [this message]
2011-04-25 15:48   ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:57     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110425113735.GE14770@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox