From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: MAKEALL problem
Date: Mon, 2 May 2011 11:27:34 +0200 [thread overview]
Message-ID: <20110502092734.GB31131@pengutronix.de> (raw)
In-Reply-To: <BANLkTin_1GZCPjmKMAOdMH-jH85PEa-7Rg@mail.gmail.com>
Hello,
On Fri, Apr 29, 2011 at 08:38:33PM +0200, Belisko Marek wrote:
> On Fri, Apr 29, 2011 at 11:30 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 10:47 Fri 29 Apr , Belisko Marek wrote:
> >> HI,
> >>
> >> On Fri, Apr 29, 2011 at 10:25 AM, Jean-Christophe PLAGNIOL-VILLARD
> >> <plagnioj@jcrosoft.com> wrote:
> >> > On 09:06 Fri 29 Apr , Belisko Marek wrote:
> >> >> Hi,
> >> >>
> >> >> current HEAD: 165a1e91f9178f160bc34c00e1d5b356cf022a00 make this problem:
> >> >>
> >> >> CROSS_COMPILE=arm-none-linux-gnueabi- ARCH=arm ./MAKEALL
> >> >> Building arm a9m2410_defconfig
> >> >> Configure: ./MAKEALL: 266: Bad substitution
> >> >>
> >> >> --------------------- SUMMARY ----------------------------
> >> >> defconfigs compiled: 0
> >> >> compiled in 10s
> >> >> ----------------------------------------------------------
> >> >>
> >> >> Am I missing something or it's really broken?
> >> > no I use it evreyday on barebox or linux
> >> >
> >> > which shell are you using
> >> GNOME Terminal 2.32.1
> > it's your terminal
> >
> > which shell sh/bash/dash/others?
> After some googling and check MAKEALL with checkbashism script this
> patch fix my problem (work fine on Ubuntu):
>
> 1. PIPESTATUS is bashism but hard to replace with something valuable in dash
> s ojust remove bash array handling
>
> 2. source is also bashism. fix it with . replacement.
>
> diff --git a/MAKEALL b/MAKEALL
> index e987de2..6c0d017 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -77,7 +77,7 @@ stats() {
> }
>
> check_pipe_status() {
> - for i in "${PIPESTATUS[@]}"
> + for i in ${PIPESTATUS}
> do
> [ $i -gt 0 ] && return 1
> done
> @@ -234,7 +234,7 @@ then
> CONFIG="./${CONFIG}"
> fi
>
> - source "${CONFIG}"
> + . "${CONFIG}"
> fi
>
> [ -d "${LOGDIR}" ] || mkdir ${LOGDIR} || exit 1
Maybe instead use
-#!/bin/sh
+#!/bin/bash
? (I'd fix s/source/./ anyhow.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-05-02 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 7:06 Belisko Marek
2011-04-29 8:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29 8:47 ` Belisko Marek
2011-04-29 9:30 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29 9:42 ` Belisko Marek
2011-04-29 18:38 ` Belisko Marek
2011-05-02 9:27 ` Uwe Kleine-König [this message]
[not found] ` <BANLkTinr-veuyxksGrtbk3o49-Pcc1uY-g@mail.gmail.com>
2011-05-02 9:41 ` Uwe Kleine-König
2011-05-02 9:50 ` [PATCH] Make MAKEALL a bash script Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502092734.GB31131@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox