From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [Patch/master] pr_warn() must be pr_warning() instead
Date: Sat, 28 May 2011 21:29:30 +0200 [thread overview]
Message-ID: <20110528192930.GM9907@pengutronix.de> (raw)
In-Reply-To: <201105262139.12927.jbe@pengutronix.de>
On Thu, May 26, 2011 at 09:39:12PM +0200, Juergen Beisert wrote:
> Fixing the following warning and error message:
> [...]
> drivers/mci/mci-core.c: In function 'mci_card_probe':
> drivers/mci/mci-core.c:1195:3: warning: implicit declaration of function 'pr_warn'
> [...]
> drivers/built-in.o: In function `mci_card_probe':
> /home/jb/work/Pengutronix/barebox-development/barebox-git/drivers/mci/mci-core.c:1195: undefined reference to `pr_warn'
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index a06c997..79c5e82 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1192,7 +1192,7 @@ static int mci_card_probe(struct device_d *mci_dev)
> /* reset the card */
> rc = mci_go_idle(mci_dev);
> if (rc) {
> - pr_warn("Cannot reset the SD/MMC card\n");
> + pr_warning("Cannot reset the SD/MMC card\n");
The kernel has
#define pr_warn pr_warning
Maybe barebox should get that, too?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-05-28 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:39 Juergen Beisert
2011-05-28 19:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110528192930.GM9907@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox