From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] import linux __iowrite32/64_copy support
Date: Sat, 4 Jun 2011 14:56:15 +0200 [thread overview]
Message-ID: <20110604125615.GA11298@game.jcrosoft.org> (raw)
In-Reply-To: <001801cc21bc$4677db10$d3679130$@cpdesign.com.au>
On 17:02 Fri 03 Jun , Marc Reilly wrote:
> Hi,
>
> <snip>
>
> > +/**
> > + * __iowrite64_copy - copy data to MMIO space, in 64-bit or 32-bit
> > +units
> > + * @to: destination, in MMIO space (must be 64-bit aligned)
> > + * @from: source (must be 64-bit aligned)
> > + * @count: number of 64-bit quantities to copy
> > + *
> > + * Copy data from kernel space to MMIO space, in units of 32 or 64 bits
> > +at a
> > + * time. Order of access is not guaranteed, nor is a memory barrier
> > + * performed afterwards.
> > + */
> > +void __attribute__((weak)) __iowrite64_copy(void __iomem *to,
> > + const void *from,
> > + size_t count)
> > +{
> > +#ifdef CONFIG_64BIT
> > + u64 __iomem *dst = to;
> > + const u64 *src = from;
> > + const u64 *end = src + count;
> > +
> > + while (src < end)
> > + __raw_writeq(*src++, dst++);
> > +#else
> > + __iowrite32_copy(to, from, count * 2); #endif }
> > +
> > +EXPORT_SYMBOL_GPL(__iowrite64_copy);
> > --
>
> Is this missing #endif for CONFIG_64BIT ?
no in the original here it's present
please double check your e-mail
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-06-04 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 15:51 Jean-Christophe PLAGNIOL-VILLARD
2011-06-03 7:02 ` Marc Reilly
2011-06-04 12:56 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-06-06 6:22 ` Sascha Hauer
2011-06-06 9:16 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110604125615.GA11298@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox