From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QTWZb-0000hk-Rr for barebox@lists.infradead.org; Mon, 06 Jun 2011 09:58:17 +0000 Date: Mon, 6 Jun 2011 11:58:13 +0200 From: Sascha Hauer Message-ID: <20110606095813.GE23771@pengutronix.de> References: <1307351484-5159-1-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1307351484-5159-1-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2 v2] complete: add device name complete support To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Mon, Jun 06, 2011 at 11:11:23AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > common/complete.c | 24 ++++++++++++++++++++++++ > 1 files changed, 24 insertions(+), 0 deletions(-) Sorry, this does not work. Pressing eth on an empty command line expands to ethact (correct, this is a command) eth0 (almost correct, it misses the '=') 'ls ' expands to ls env/ (correct, this is a directory) ls eth0 (incorrect, no valid expansion) 'ls n expands to ls nand0 (incorrect, this is a device name and can't be used here= ls nfsroot= (incorrect, no valid expansion) Please check the context in which you are calling the different complete functions like I suggested in my comment to the last patch. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox