From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Hubert Feurstein <h.feurstein@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] macb: add support for board specific get_ethaddr function
Date: Wed, 22 Jun 2011 09:08:45 +0200 [thread overview]
Message-ID: <20110622070845.GY7881@game.jcrosoft.org> (raw)
In-Reply-To: <BANLkTin-bmxQooWJAp7sRBU6bimNx0ogYA@mail.gmail.com>
On 23:51 Tue 21 Jun , Hubert Feurstein wrote:
> 2011/6/21 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> >> @@ -47,6 +48,7 @@ void at91_add_device_nand(struct atmel_nand_data *data);
> >> struct at91_ether_platform_data {
> >> unsigned int flags;
> >> int phy_addr;
> >> + int (*get_ethaddr)(struct eth_device*, unsigned char *adr);
> > can we find a generic way?
> a generic way would be to simply call
> 'dev_set_param(get_device_by_name("eth0"), "ethaddr", macbuffer)'
> somewhere after at91_add_device_eth(...) in your init. Then you don't
> need the callback at all to setup the mac-address.
I more in mind an api to update the get/set_ethaddr without specific hookin
each driver
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-06-22 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 13:55 Hubert Feurstein
2011-06-21 12:56 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-21 21:51 ` Hubert Feurstein
2011-06-22 7:08 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622070845.GY7881@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=h.feurstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox