mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] include/linux/stat.h: make MIPS arch possible.
Date: Mon, 27 Jun 2011 12:01:31 +0200	[thread overview]
Message-ID: <20110627100131.GC6069@pengutronix.de> (raw)
In-Reply-To: <1309158909-19978-1-git-send-email-antonynpavlov@gmail.com>

On Mon, Jun 27, 2011 at 11:15:08AM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  include/linux/stat.h |   56 ++++++++++++++++++++++++-------------------------
>  1 files changed, 27 insertions(+), 29 deletions(-)
> 
> diff --git a/include/linux/stat.h b/include/linux/stat.h

This version of include/linux/stat.h is copied from Linux in the Stone
Age. It only has ifdefs to support architecture specific userspace formats
of this struct. We should remove all ifdefs and just use a common
version of struct stat for all architectures.
So please just remove all code inside __PPC__ and __MIPS__ in this file.

Sascha

> index 10103d4..c12ff57 100644
> --- a/include/linux/stat.h
> +++ b/include/linux/stat.h
> @@ -65,34 +65,7 @@ struct stat {
>  	unsigned long  	__unused5;
>  };
>  
> -#else
> -
> -struct stat {
> -	unsigned short st_dev;
> -	unsigned short __pad1;
> -	unsigned long st_ino;
> -	unsigned short st_mode;
> -	unsigned short st_nlink;
> -	unsigned short st_uid;
> -	unsigned short st_gid;
> -	unsigned short st_rdev;
> -	unsigned short __pad2;
> -	unsigned long  st_size;
> -	unsigned long  st_blksize;
> -	unsigned long  st_blocks;
> -	unsigned long  st_atime;
> -	unsigned long  __unused1;
> -	unsigned long  st_mtime;
> -	unsigned long  __unused2;
> -	unsigned long  st_ctime;
> -	unsigned long  __unused3;
> -	unsigned long  __unused4;
> -	unsigned long  __unused5;
> -};
> -
> -#endif	/* __ARM__ */
> -
> -#if defined (__MIPS__)
> +#elif defined(__MIPS__)
>  
>  struct stat {
>  	dev_t           st_dev;
> @@ -121,7 +94,32 @@ struct stat {
>  	long            st_pad4[14];
>  };
>  
> -#endif	/* __MIPS__ */
> +#else
> +
> +struct stat {
> +	unsigned short st_dev;
> +	unsigned short __pad1;
> +	unsigned long st_ino;
> +	unsigned short st_mode;
> +	unsigned short st_nlink;
> +	unsigned short st_uid;
> +	unsigned short st_gid;
> +	unsigned short st_rdev;
> +	unsigned short __pad2;
> +	unsigned long  st_size;
> +	unsigned long  st_blksize;
> +	unsigned long  st_blocks;
> +	unsigned long  st_atime;
> +	unsigned long  __unused1;
> +	unsigned long  st_mtime;
> +	unsigned long  __unused2;
> +	unsigned long  st_ctime;
> +	unsigned long  __unused3;
> +	unsigned long  __unused4;
> +	unsigned long  __unused5;
> +};
> +
> +#endif	/* __ARM__ */
>  
>  #ifdef __cplusplus
>  }
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2011-06-27 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27  7:15 Antony Pavlov
2011-06-27  7:39 ` Franck JULLIEN
2011-06-27 10:01 ` Sascha Hauer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-26 13:20 Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627100131.GC6069@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox