mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] Add MIPS arch support to barebox
Date: Tue, 28 Jun 2011 12:06:29 +0200	[thread overview]
Message-ID: <20110628100629.GJ6069@pengutronix.de> (raw)
In-Reply-To: <BANLkTim9Dx3uuE-3v33PdmpSpv9K30zhcA@mail.gmail.com>

On Tue, Jun 28, 2011 at 01:37:46PM +0400, Antony Pavlov wrote:
> On 28/06/2011, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > On 21:13 Mon 27 Jun     , Antony Pavlov wrote:
> >> Only supported board is qemu malta:
> >>   * barebox works in uncached memory;
> >>   * no peripherals support, but serial port.
> >
> > please take a look on here
> > http://git.jcrosoft.org/git?p=barebox.git;a=shortlog;h=refs/heads/mips
> >
> > the work start by Shinya Kuribayashi to support mips and barebox
> >
> > maybe you can merge both
> >
> 
> I took a look on it.
> 
> I can build 'qemu' target with default config, but I can't see
> any output in emulator.
> 
> I can't even build 'malta' target with default config.
> 
> Is it runnable at all?
> 
> I think, that Shinya's concepts can be used in the future, but they
> are very complex for initial mips support.
> 
> IMHO, the Shinya's code is redundant (> 200K ) --- initial support
> must be as small as possible.

+1 for starting small.

> 
> The file Kconfig is overcomplicated. Many variables are really unused:
>  DMA_NONCOHERENT,
>  SWAP_IO_SPACE
>  HW_HAS_PCI
>  SYS_SUPPORTS_{32,64}BIT_KERNEL
>  SYS_SUPPORTS_ARBIT_HZ
>   and others
> 
> In other hand the options ARCH_TEXT_BASE and CPU_BIG_ENDIAN are useful
> just now, but I have missed them.
> 
> But now I see, that I can make my mips support better --- split big
> patch and make some parts of code configurable.

I forgot to say, it's good to split the board support and the
architecture support.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-06-28 10:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 17:13 [PATCH 1/2] include/linux/stat.h: make struct stat unified Antony Pavlov
2011-06-27 17:13 ` [PATCH 2/2] Add MIPS arch support to barebox Antony Pavlov
2011-06-28  5:11   ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-28  6:14     ` Antony Pavlov
2011-06-28  9:37     ` Antony Pavlov
2011-06-28 10:06       ` Sascha Hauer [this message]
2011-06-28 13:29       ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-28 16:23         ` Shinya Kuribayashi
2011-06-28  7:21   ` Sascha Hauer
2011-06-28  9:03     ` Antony Pavlov
2011-06-28 15:06   ` Shinya Kuribayashi
2011-06-28 15:42     ` Antony Pavlov
2011-06-28  6:40 ` [PATCH 1/2] include/linux/stat.h: make struct stat unified Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110628100629.GJ6069@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox