[PATCH] fix: commands/bootm.c:346:2: warning: statement with no effect

[PATCH] fix: commands/bootm.c:346:2: warning: statement with no effect

[Jean-Christophe PLAGNIOL-VILLARD]

convert enable_interrupts() and disable_interrupts() to static inline
if no IRQ supoprt enable

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 include/common.h |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/common.h b/include/common.h
index 491bc98..f3353c8 100644
--- a/include/common.h
+++ b/include/common.h
@@ -116,8 +116,14 @@ void	irq_free_handler   (int);
 void	enable_interrupts  (void);
 int	disable_interrupts (void);
 #else
-#define enable_interrupts() do {} while (0)
-#define disable_interrupts() 0
+static inline void enable_interrupts(void)
+{
+}
+
+static inline int disable_interrupts(void)
+{
+	return 0;
+}
 #endif
 
 /* lib_$(ARCH)/time.c */
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fix: commands/bootm.c:346:2: warning: statement with no effect

[Sascha Hauer]

On Sat, Jul 16, 2011 at 12:42:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> convert enable_interrupts() and disable_interrupts() to static inline
> if no IRQ supoprt enable

Applied to master

Sascha

> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  include/common.h |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/include/common.h b/include/common.h
> index 491bc98..f3353c8 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -116,8 +116,14 @@ void	irq_free_handler   (int);
>  void	enable_interrupts  (void);
>  int	disable_interrupts (void);
>  #else
> -#define enable_interrupts() do {} while (0)
> -#define disable_interrupts() 0
> +static inline void enable_interrupts(void)
> +{
> +}
> +
> +static inline int disable_interrupts(void)
> +{
> +	return 0;
> +}
>  #endif
>  
>  /* lib_$(ARCH)/time.c */
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox