From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] startup.c: make DEBUG_LL output more useful
Date: Mon, 18 Jul 2011 08:46:26 +0200 [thread overview]
Message-ID: <20110718064626.GF20587@pengutronix.de> (raw)
In-Reply-To: <1310928985-30940-2-git-send-email-antonynpavlov@gmail.com>
On Sun, Jul 17, 2011 at 10:56:25PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> common/startup.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/common/startup.c b/common/startup.c
> index 00bc9a0..f8efa08 100644
> --- a/common/startup.c
> +++ b/common/startup.c
> @@ -134,13 +134,17 @@ void start_barebox (void)
>
> for (initcall = __barebox_initcalls_start;
> initcall < __barebox_initcalls_end; initcall++) {
> + PUTS_LL("<<");
> PUTHEX_LL(*initcall);
> - PUTC_LL('\n');
> result = (*initcall)();
> + PUTC_LL('>');
> if (result)
> hang();
> + PUTS_LL(">\r\n");
Looks mostly good. Can we to the \n -> \r\n conversion in PUTS_LL
instead?
Sascha
> }
>
> + PUTS_LL("initcalls done\r\n");
> +
> display_meminfo();
>
> #ifdef CONFIG_ENV_HANDLING
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-07-18 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 18:56 [PATCH 1/2] debug_ll.h: add PUTS_LL() function Antony Pavlov
2011-07-17 18:56 ` [PATCH 2/2] startup.c: make DEBUG_LL output more useful Antony Pavlov
2011-07-18 6:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718064626.GF20587@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox