From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org,
Patrice Vilchez <patrice.vilchez@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH 1/7] device: introduce resource structure to simplify resource declaration
Date: Tue, 19 Jul 2011 17:45:22 +0200 [thread overview]
Message-ID: <20110719154522.GI5727@game.jcrosoft.org> (raw)
In-Reply-To: <CAA4bVAHUF+VuSPgr1EBt1uCP+r5AnHvsw19-cJ1UNWwHKxNfWw@mail.gmail.com>
On 17:40 Tue 19 Jul , Antony Pavlov wrote:
> On 16/07/2011, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > and add multi resource per device support
> >
> > for now we keep the old map_base and size temporary but will switch all of
> > the used step by step to them resource way
> >
> > and mirror the first resource to the map_base and size if available
> >
>
> > +++ b/include/linux/ioport.h
> ...
> > +struct resource {
> > + resource_size_t start;
> > + resource_size_t size;
> > + const char *name;
> > + unsigned long flags;
> > +};
>
> In linux-2.6.39/include/linux/ioport.h:
>
> struct resource {
> resource_size_t start;
> resource_size_t end;
> const char *name;
> unsigned long flags;
> struct resource *parent, *sibling, *child;
> };
>
> So there is incompatability: barebox has 'size' field, but linux has
> 'end' field instead.
>
> Can you comment this, please?
in barebox we use size no end in the resource since the begenning
so I choose to keep it this way
and avoid the calcul end - start
if u use helper resource_size() you will no notice
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-07-19 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 10:45 Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 2/7] at91: switch to all resource declaration to "struct resource" Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 3/7] at91/serial: switch " Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 4/7] macb: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 5/7] atmel_mci: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 6/7] atmel_nand: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 10:45 ` [PATCH 7/7] dm9200: use "struct resource" instead of platform_data Jean-Christophe PLAGNIOL-VILLARD
2011-07-17 15:28 ` Sascha Hauer
2011-07-18 4:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-17 15:37 ` [PATCH 1/7] device: introduce resource structure to simplify resource declaration Sascha Hauer
2011-07-18 4:43 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-18 6:26 ` Sascha Hauer
2011-07-19 13:40 ` Antony Pavlov
2011-07-19 15:45 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719154522.GI5727@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox