From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/2] debug_ll.h: add PUTS_LL() function
Date: Wed, 20 Jul 2011 08:51:59 +0200 [thread overview]
Message-ID: <20110720065159.GQ20587@pengutronix.de> (raw)
In-Reply-To: <CAJfOKBzxdZJh7Sguoe=pQqbw=_4ebBpjnF=BgOzwZ6HD9inY2w@mail.gmail.com>
On Tue, Jul 19, 2011 at 03:14:03PM +0200, Franck JULLIEN wrote:
> 2011/7/18 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Mon, Jul 18, 2011 at 05:06:09PM +0400, Antony Pavlov wrote:
> >> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> >
> > Applied both to next.
> >
> > Thanks
> > Sascha
> >
> >> ---
> >> include/debug_ll.h | 13 +++++++++++++
> >> 1 files changed, 13 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/debug_ll.h b/include/debug_ll.h
> >> index e99ae7d..6b1b174 100644
> >> --- a/include/debug_ll.h
> >> +++ b/include/debug_ll.h
> >> @@ -35,9 +35,22 @@
> >> ch = ((v >> (i*4)) & 0xf);\
> >> ch += (ch >= 10) ? 'a' - 10 : '0';\
> >> PUTC_LL (ch); }})
> >> +
> >> +static __inline__ void PUTS_LL(char * str)
> >> +{
> >> + while (*str) {
> >> + if (*str == '\n') {
> >> + PUTC_LL('\r');
> >> + }
> >> + PUTC_LL(*str);
> >> + str++;
> >> + }
> >> +}
> >> +
> >> #else
> >> # define PUTC_LL(c) do {} while (0)
> >> # define PUTHEX_LL(v) do {} while (0)
> >> +# define PUTS_LL(c) do {} while (0)
> >>
> >> #endif
> >>
>
> Is there any reason for not using vsprintf in a printf_ll function
> which would use puts_ll / putc_ll ??
You would at least need a writable string buffer. I'd rather like to
keep the ll functions as simple as possible. Otherwise you end up
debugging the debug functions while hunting some lowlevel problem.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-07-20 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 13:06 Antony Pavlov
2011-07-18 13:06 ` [PATCH v2 2/2] startup.c: make DEBUG_LL output more useful Antony Pavlov
2011-07-18 13:26 ` [PATCH v2 1/2] debug_ll.h: add PUTS_LL() function Franck JULLIEN
2011-07-18 13:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-18 13:59 ` Franck JULLIEN
2011-07-18 21:03 ` Sascha Hauer
2011-07-18 21:04 ` Sascha Hauer
2011-07-19 13:14 ` Franck JULLIEN
2011-07-20 6:51 ` Sascha Hauer [this message]
2011-07-20 7:14 ` Franck JULLIEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110720065159.GQ20587@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox