mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mips: fix mipsel toolchains support to compile BIG_ENDIAN board
Date: Tue, 26 Jul 2011 14:21:57 +0200	[thread overview]
Message-ID: <20110726122157.GM20587@pengutronix.de> (raw)
In-Reply-To: <1311655236-6684-1-git-send-email-plagnioj@jcrosoft.com>

On Tue, Jul 26, 2011 at 06:40:36AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/mips/Makefile |   42 ++++++++++++++++++++++++++++++++++++++----
>  1 files changed, 38 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 86b4b80..72434d4 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -1,20 +1,54 @@
> +#
> +# Select the object file format to substitute into the linker script.
> +#
> +ifdef CONFIG_CPU_LITTLE_ENDIAN
> +32bit-tool-archpref	= mipsel
> +64bit-tool-archpref	= mips64el
> +32bit-bfd		= elf32-tradlittlemips
> +64bit-bfd		= elf64-tradlittlemips
> +32bit-emul		= elf32ltsmip
> +64bit-emul		= elf64ltsmip
> +else
> +32bit-tool-archpref	= mips
> +64bit-tool-archpref	= mips64
> +32bit-bfd		= elf32-tradbigmips
> +64bit-bfd		= elf64-tradbigmips
> +32bit-emul		= elf32btsmip
> +64bit-emul		= elf64btsmip
> +endif

I'm not convinced that introducing magic for finding a cross toolchain
is a good idea. The corresponding kernel code goes back to the pre
2.6.12 era and I think it wouldn't find its way mainline nowadays.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2011-07-26 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  4:40 Jean-Christophe PLAGNIOL-VILLARD
2011-07-26  7:15 ` Antony Pavlov
2011-07-26  7:17 ` [PATCH] MIPS: try to select cross-compiler (if not set) Antony Pavlov
2011-07-26 12:21 ` Sascha Hauer [this message]
2011-07-26 18:28 ` [PATCH] MIPS: fix fix mipsel toolchains support to compile BIG_ENDIAN board Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110726122157.GM20587@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox