From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc@milas.spb.ru>
Cc: barebox@lists.infradead.org
Subject: Re: I2C support to PCM-038 board
Date: Fri, 12 Aug 2011 11:06:53 +0200 [thread overview]
Message-ID: <20110812090653.GN31404@pengutronix.de> (raw)
In-Reply-To: <1313059025.19612@milas.spb.ru>
On Thu, Aug 11, 2011 at 02:37:05PM +0400, Alexander Shiyan wrote:
> Hello.
>
> Please review and apply this simple patch.
> Thanks!
>
> diff -urN barebox-v2011.08.0.orig/arch/arm/boards/pcm038/pcm038.c barebox-v2011.08.0/arch/arm/boards/pcm038/pcm038.c
> --- barebox-v2011.08.0.orig/arch/arm/boards/pcm038/pcm038.c 2011-08-04 16:42:13.000000000 +0400
> +++ barebox-v2011.08.0/arch/arm/boards/pcm038/pcm038.c 2011-08-11 11:10:16.000000000 +0400
> @@ -40,6 +40,7 @@
> #include <mach/imx-pll.h>
> #include <mach/imxfb.h>
> #include <asm/mmu.h>
> +#include <i2c/i2c.h>
> #include <usb/isp1504.h>
> #include <mach/spi.h>
> #include <mach/iomux-mx27.h>
> @@ -261,6 +262,14 @@
> PD23_AF_USBH2_DATA2,
> PD24_AF_USBH2_DATA1,
> PD26_AF_USBH2_DATA5,
> +#ifdef CONFIG_I2C
> + /* I2C1 */
> + PD17_PF_I2C_DATA | GPIO_PUEN,
> + PD18_PF_I2C_CLK,
> + /* I2C2 */
> + PC5_PF_I2C2_SDA,
> + PC6_PF_I2C2_SCL,
> +#endif
> };
>
> pcm038_mmu_init();
> @@ -298,6 +307,12 @@
> register_device(&sram_dev);
> imx27_add_fb(&pcm038_fb_data);
>
> +#ifdef CONFIG_I2C
> + PCCR0 |= PCCR0_I2C1_EN | PCCR0_I2C2_EN;
> + imx27_add_i2c0(NULL);
> + imx27_add_i2c1(NULL);
> +#endif
Please remove the #ifdef CONFIG_I2C
Sascha
> +
> #ifdef CONFIG_USB
> pcm038_usbh_init();
> register_device(&usbh2_dev);
> diff -urN barebox-v2011.08.0.orig/arch/arm/mach-imx/include/mach/devices-imx27.h barebox-v2011.08.0/arch/arm/mach-imx/include/mach/devices-imx27.h
> --- barebox-v2011.08.0.orig/arch/arm/mach-imx/include/mach/devices-imx27.h 2011-08-04 16:42:13.000000000 +0400
> +++ barebox-v2011.08.0/arch/arm/mach-imx/include/mach/devices-imx27.h 2011-08-11 11:20:26.000000000 +0400
> @@ -11,6 +11,11 @@
> return imx_add_i2c((void *)IMX_I2C1_BASE, 0, pdata);
> }
>
> +static inline struct device_d *imx27_add_i2c1(struct i2c_platform_data *pdata)
> +{
> + return imx_add_i2c((void *)IMX_I2C2_BASE, 1, pdata);
> +}
> +
> static inline struct device_d *imx27_add_uart0(void)
> {
> return imx_add_uart((void *)IMX_UART1_BASE, 0);
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-08-12 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 10:37 Alexander Shiyan
2011-08-12 9:06 ` Sascha Hauer [this message]
2011-08-12 9:21 ` shc
2011-08-17 7:39 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812090653.GN31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc@milas.spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox