add_usb_ehci_device() don't set resource size

add_usb_ehci_device() don't set resource size

[Antony Pavlov]

Hi!

add_usb_ehci_device() don't set resource size, it only set start address:

struct device_d *add_usb_ehci_device(int id, resource_size_t hccr,
                resource_size_t hcor, void *pdata)
{
        struct device_d *dev;

        dev = alloc_device("ehci", id, pdata);
        dev->resource = xzalloc(sizeof(struct resource) * 2);
        dev->num_resources = 2;
        dev->resource[0].start = hccr;
        dev->resource[0].flags = IORESOURCE_MEM;
        dev->resource[1].start = hcor;
        dev->resource[1].flags = IORESOURCE_MEM;

        register_device(dev);

        return dev;
}

So on my Tegra board I have this:

toshiba ac100> / devinfo ehci0
resources:
num   : 0
start : 0xc5000100
size  : 0x00000000
        ^^^^^^^^^^
num   : 1
start : 0xc5000140
size  : 0x00000000
        ^^^^^^^^^^
driver: ehci

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: add_usb_ehci_device() don't set resource size

[Sascha Hauer]

On Wed, Aug 24, 2011 at 06:30:35PM +0400, Antony Pavlov wrote:
> Hi!
> 
> add_usb_ehci_device() don't set resource size, it only set start address:

Yeah, the resource size is barely handled in barebox. Even if they
exist, most if not all drivers do not check it.

> So on my Tegra board I have this:
> 
> toshiba ac100> / devinfo ehci0
> resources:
> num   : 0
> start : 0xc5000100
> size  : 0x00000000
>         ^^^^^^^^^^
> num   : 1
> start : 0xc5000140
> size  : 0x00000000
>         ^^^^^^^^^^

This does not look good, patches welcome.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox