mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Mark Vels <mark.vels@team-embedded.nl>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 0/9] Catch-up/clean-up doxygen documentation
Date: Thu, 3 Nov 2011 08:26:45 +0100	[thread overview]
Message-ID: <20111103072645.GC16886@pengutronix.de> (raw)
In-Reply-To: <cover.1320141619.git.mark.vels@team-embedded.nl>

Hi Mark,

On Tue, Nov 01, 2011 at 11:09:36AM +0100, Mark Vels wrote:
> I just started using BB and was a little anoyed by the fact that although there
> is plenty of documentation in the source code, it did not show up in the
> generated documentation. I think the availability of simple, clean and
> structured information is important for the success of BB and make it 
> enjoyable for developers to get aquainted with BB. Therefore I put some effort
> in getting the doxygen output up to date.
> 
> This patch set tries to update the shell command documentation.
> 
> A short summary of the changes in this patch set:
> - The first few patches deal with orphan pages; pages that were not
>   linked to directly and hence showed up at top-level in the Doxygen output
>   HTML.
> 
> - In the command overview page, a separation between platform-independent
>   and dependent code has been made. In some cases I found 3 versions/
>   implementations of the same command on different ARCHs, including 3 copies
>   of the same documentation. I will try to come up with a solution for this
>   and make sure we have consistent command implementations across different
>   platforms and architectures which IMHO is important.
> 
> - In a few cases I found the command help information inside an #ifdef. I took
>   the liberty to move the BAREBOX_CMD_HELP_* macros outside these conditional
>   sections so that the documentation for that command always shows up in the
>   Doxygen-generated output. Of course the availability of the commands and the
>   help text in bb should not have been altered.
> 
> - An attempt is made to make consistent use of the BAREBOX_CMD_HELP_* macro's.
>   Also some clean-up was done or small amendments to the documentation.
> 
> - I changed a number of syntax errors in the drivers/mtd/nand directory. It was
>   not my intention to touch source-generated documentation but decided to fix a
>   number of syntax errors to make a first attempt to get rid of all Doxygen 
>   warnings and make the output usable again.
> 
> - I also tried to make sure all shell command documentation now uses the same
>   format for describing cli options (for example the use of [OPTIONS] for 
>   options and [<arg1>] for an optional argument. This style is what I saw
>   for most commands already so I just tried to make it's use consistent.
> 
> I realise that the distribution of the number of changes is not optimal,
> this patch set grew considerably bigger as I progressed. In the end it is
> just a big collection of lots of small and trivial changes and I hope you can 
> still find the motivation to review these patches and provide me with some 
> feedback.

Thank you for your efforts, I really appreciate this. I hoped though
that I can shift over the documentation to
http://wiki.barebox.org/doku.php as this is maintainable without
patching the source code. So I wonder if you didn't know about this
website at all (could be my bad, I should have communicated this more
clearly) or are there other problems with the documentation in the wiki?
Maybe in the end the doxygen documentation is more what people actually
want?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2011-11-03  7:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 10:09 Mark Vels
2011-11-01 10:09 ` [PATCH 1/9] trivial: relocate doxygen help page for time command Mark Vels
2011-11-01 10:09 ` [PATCH 2/9] trivial: relocate doxygen help page for led command Mark Vels
2011-11-01 10:09 ` [PATCH 3/9] trivial: reorganize crc32 command doxygen output Mark Vels
2011-11-01 10:09 ` [PATCH 4/9] trivial: fix doxygen error in dlink-dir-320.dox Mark Vels
2011-11-01 10:09 ` [PATCH 5/9] trivial: De-orphan NAND doxygen output and fix @param syntax Mark Vels
2011-11-01 10:09 ` [PATCH 6/9] docs: Enable BAREBOX_CMD_HELP_TEXT() in generated documentation Mark Vels
2011-11-01 10:09 ` [PATCH 7/9] doxygen: Enable LONGHELP output in generated output Mark Vels
2011-11-01 10:09 ` [PATCH 8/9] trivial: Small change in page link title Mark Vels
2011-11-01 10:09 ` [PATCH 9/9] help: update of shell commands doxygen/online help documentation Mark Vels
2011-11-03  7:26 ` Sascha Hauer [this message]
2011-11-03 12:48   ` [RFC PATCH 0/9] Catch-up/clean-up doxygen documentation Mark Vels
2011-11-04  9:06     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103072645.GC16886@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mark.vels@team-embedded.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox