From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] at91: add config option for ohci driver
Date: Fri, 11 Nov 2011 12:05:06 +0100 [thread overview]
Message-ID: <20111111110506.GO16886@pengutronix.de> (raw)
In-Reply-To: <20111111104614.GC15318@game.jcrosoft.org>
On Fri, Nov 11, 2011 at 11:46:14AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:03 Wed 09 Nov , Hubert Feurstein wrote:
> > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > drivers/usb/host/Kconfig | 4 ++++
> > drivers/usb/host/Makefile | 2 +-
> > 2 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 929eb89..96e09e2 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -7,3 +7,7 @@ config USB_EHCI_OMAP
> >
> > config USB_OHCI
> > bool "OHCI driver"
> > +
> > +config USB_OHCI_AT91
> > + depends on ARCH_AT91
> > + bool "AT91 OHCI driver"
> Sacahs can you revert this one
>
> there is no need to have any select for the user
>
> if you enalbe the OHCI it must just enable it on AT91 directly otherwise you
> have a OHCI enable but without driver
What the patch fixes is that ohci-at91.c is compiled even when USB is
completely disabled, so reverting just it is not a good solution. I'm
open to better solutions.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-11-11 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 16:03 Hubert Feurstein
2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-10 17:03 ` Hubert Feurstein
2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-11 11:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111110506.GO16886@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox