mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] mci: implement multi block write
Date: Fri, 11 Nov 2011 12:59:13 +0100	[thread overview]
Message-ID: <20111111115913.GU16886@pengutronix.de> (raw)
In-Reply-To: <CAAfyv359sAv-NPH8fdSGNSQG0np5JEDYxzvf1ivNQ4hWZ0YPsw@mail.gmail.com>

On Fri, Nov 11, 2011 at 12:47:04PM +0100, Belisko Marek wrote:
> >
> > -       return mci_send_cmd(mci_dev, &cmd, &data);
> > +       ret = mci_send_cmd(mci_dev, &cmd, &data);
> > +       if (ret)
> > +               return ret;
> > +
> > +
> Necessary 2 new lines here?

I removed one of them and it still works, so no ;)

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-11-11 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 11:38 [PATCH] mci multiblock write Sascha Hauer
2011-11-11 11:38 ` [PATCH 1/2] mci: implement multi block write Sascha Hauer
2011-11-11 11:47   ` Belisko Marek
2011-11-11 11:59     ` Sascha Hauer [this message]
2011-11-11 11:38 ` [PATCH 2/2] mci: remove unnecessary loops Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111111115913.GU16886@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox