Re: [PATCH 08/13] DISK: Add common partition handling for disk like media

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Nov 16, 2011 at 10:24:22AM +0100, Juergen Beisert wrote:
> This covers disk like media like SD card, CF cards, regular hard disks and also
> USB mass storage devices. Most common used partition table is still of DOS type.
> This implementation is prepared to support more partition types in the future.
> 
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> ---
>  common/Kconfig      |   18 ++++
>  common/Makefile     |    2 +
>  common/partitions.c |  229 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/disks.h     |    2 +
>  4 files changed, 251 insertions(+), 0 deletions(-)
>  create mode 100644 common/partitions.c
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 8e96920..1318e7d 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -406,6 +406,24 @@ config PARTITION
 +
> +/**
> + * Try to collect partition information on the given block device
> + * @param blk Block device to examine
> + * @return 0 most of the time, negative value else
> + *
> + * It is not a failure if no partition information is found
> + */
> +int parse_partition_table(struct block_device *blk)
> +{
> +	int i;
> +	int rc = 0;
> +
> +#ifdef CONFIG_PARTITION_DISK_DOS
> +	if (pdesc.used_entries == 0)
> +		try_dos_partition(blk);
> +#endif
> +
> +	if (pdesc.used_entries != 0) {

So every block device that comes in uses the same global variable. We
should support multiple block devices.
Also it should be possible to unregister the partitions on a block
device.

> +		/* at least one partition description found */
> +		for (i = 0; i < pdesc.used_entries; i++) {
> +			rc = register_one_partition(blk, &pdesc.parts[i], i);
> +			if (rc != 0)
> +				dev_err(blk->dev,
> +					"Failed to register partition %d on %s (%d)\n",
> +					i, blk->cdev.name, rc);
> +			if (rc != -ENODEV)
> +				rc = 0;
> +		}
> +	}
> +
> +	return rc;
> +}
> diff --git a/include/disks.h b/include/disks.h
> index ec136d4..9932750 100644
> --- a/include/disks.h
> +++ b/include/disks.h
> @@ -36,4 +36,6 @@ struct partition_entry {
>  	uint32_t partition_size; /*! Start of the partition in LBA notation */
>  } __attribute__ ((packed));
>  
> +extern int parse_partition_table(struct block_device*);
> +
>  #endif /* DISKS_H */
> -- 
> 1.7.7.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox