From: Sascha Hauer <s.hauer@pengutronix.de>
To: Hubert Feurstein <h.feurstein@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] eeprom/at25: add erase support
Date: Tue, 22 Nov 2011 10:19:26 +0100 [thread overview]
Message-ID: <20111122091926.GE27267@pengutronix.de> (raw)
In-Reply-To: <1321882291-26290-1-git-send-email-h.feurstein@gmail.com>
On Mon, Nov 21, 2011 at 02:31:31PM +0100, Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> drivers/eeprom/at25.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
Do we need this? We normally only have erase functions for devices that
need it, namely flashes.
Sascha
>
> diff --git a/drivers/eeprom/at25.c b/drivers/eeprom/at25.c
> index 8a979d5..39c5846 100644
> --- a/drivers/eeprom/at25.c
> +++ b/drivers/eeprom/at25.c
> @@ -237,10 +237,25 @@ static off_t at25_ee_lseek(struct cdev *cdev, off_t off)
> return off;
> }
>
> +static int at25_ee_erase(struct cdev *cdev, size_t count, unsigned long offset)
> +{
> + int result;
> + void *buf = xzalloc(count);
> +
> + result = at25_ee_write(cdev, buf, count, offset, 0);
> + free(buf);
> +
> + if (result < 0)
> + return result;
> +
> + return 0;
> +}
> +
> static struct file_operations at25_fops = {
> .read = at25_ee_read,
> .write = at25_ee_write,
> .lseek = at25_ee_lseek,
> + .erase = at25_ee_erase,
> };
>
> static int at25_probe(struct device_d *dev)
> --
> 1.7.4.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-22 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 13:31 Hubert Feurstein
2011-11-22 9:19 ` Sascha Hauer [this message]
2011-11-22 9:58 ` Hubert Feurstein
2011-11-22 10:45 ` Sascha Hauer
2011-11-24 13:02 ` Hubert Feurstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122091926.GE27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=h.feurstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox