From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] sanbox: add linux_execve and linux_exec command
Date: Tue, 22 Nov 2011 21:07:48 +0100 [thread overview]
Message-ID: <20111122200748.GM27267@pengutronix.de> (raw)
In-Reply-To: <1319363961-4944-1-git-send-email-plagnioj@jcrosoft.com>
Hi Jean Christophe,
On Sun, Oct 23, 2011 at 05:59:21PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this will allow to execute a program of the host from barebox
> +
> +#include <common.h>
> +#include <command.h>
> +#include <mach/linux.h>
> +
> +static int do_linux_exec(struct command *cmdtp, int argc, char *argv[])
> +{
> + int ret;
> + char **newargv;
> + char *newenv[] = { NULL };
> + int i, j;
> +
> + if (argc < 2)
> + return 1;
> +
> + newargv = xzalloc(sizeof(char*) * argc);
> +
> + for (j = 0, i = 1; i < argc; i++, j++)
> + newargv[j] = argv[i];
> +
> + newargv[j] = NULL;
> + ret = linux_execve(argv[1], newargv, newenv);
> +
> + if (ret)
> + return 1;
> +
> + return 0;
You are loosing memory here.
Sascha
> +}
> +
> +BAREBOX_CMD_HELP_START(linux_exec)
> +BAREBOX_CMD_HELP_USAGE("linux_exec ...\n")
> +BAREBOX_CMD_HELP_SHORT("Execute a command on the host\n")
> +BAREBOX_CMD_HELP_END
> +
> +BAREBOX_CMD_START(linux_exec)
> + .cmd = do_linux_exec,
> + .usage = "Execute a command on the host",
> + BAREBOX_CMD_HELP(cmd_linux_exec_help)
> +BAREBOX_CMD_END
> --
> 1.7.7
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-11-22 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 9:59 Jean-Christophe PLAGNIOL-VILLARD
2011-11-22 7:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-22 20:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122200748.GM27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox