From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 12/13] ATA Disk Support: Add support for native ATA type drives
Date: Thu, 24 Nov 2011 12:28:51 +0100 [thread overview]
Message-ID: <201111241228.51594.jbe@pengutronix.de> (raw)
In-Reply-To: <20111117204604.GU27267@pengutronix.de>
Sascha Hauer wrote:
> On Wed, Nov 16, 2011 at 10:24:26AM +0100, Juergen Beisert wrote:
> > Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> > ---
> > drivers/ata/Kconfig | 12 +
> > drivers/ata/Makefile | 1 +
> > drivers/ata/disk_ata_drive.c | 631
> > ++++++++++++++++++++++++++++++++++++++++++ include/ata_drive.h |
> > 194 +++++++++++++
> > 4 files changed, 838 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/ata/disk_ata_drive.c
> > create mode 100644 include/ata_drive.h
> >
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index 86b5673..0a15863 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -24,6 +24,18 @@ config DISK_BIOS
> > media to work on. Disadvantage is: Due to its 16 bit nature it is
> > slow.
> >
> > +config DISK_ATA
> > + bool "ATA type drives"
> > + select DISK_DRIVE
> > + help
> > + Support for native ATA/IDE drives
> > +
> > +config DISK_LE_ATTACHED
> > + bool "little endianess attachment"
> > + depends on DISK_ATA
> > + help
> > + How the drive's data port (16 bit) is connected to the CPU: LE or BE
>
> No. We have platform data for this stuff.
The platform data will imply a runtime decision. While this approach is a
compile time decision.
I will change it.
> [...]
> > +
> > + if (timeout) {
> > + pr_debug("%s: Finished with %u us remaining\n", __func__, timeout);
>
> This seems *very* noisy.
>
> > + return 0;
> > + }
> > +
> > + pr_debug("%s: Waiting timed out!\n", __func__);
>
> We have a pr_debug here and additionally in each function calling this.
> I think having it here is enough.
Ups. My mistake. Leftover from debugging.
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-24 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 9:24 Rework of handling disk like media Juergen Beisert
2011-11-16 9:24 ` [PATCH 01/13] USB Mass Storage driver: Fix compile time warning Juergen Beisert
2011-11-16 9:24 ` [PATCH 02/13] Create a unique cdev number for on demand devices Juergen Beisert
2011-11-16 9:24 ` [PATCH 03/13] ATA/DISK: Add generic disk support when enabling the BIOS disk driver Juergen Beisert
2011-11-16 9:24 ` [PATCH 04/13] ATA/DISK: Enabling write support does not belong to 'drive types' Juergen Beisert
2011-11-16 9:24 ` [PATCH 05/13] ATA/DISK: Reorganize file structure and names for future updates Juergen Beisert
2011-11-16 9:24 ` [PATCH 06/13] ATA/DISK: The BIOS based disk driver is not an interface Juergen Beisert
2011-11-16 9:24 ` [PATCH 07/13] ATA/DISK: Share important constants and structures Juergen Beisert
2011-11-16 9:24 ` [PATCH 08/13] DISK: Add common partition handling for disk like media Juergen Beisert
2011-11-17 16:17 ` Sascha Hauer
2011-11-18 8:26 ` Juergen Beisert
2011-11-18 8:51 ` Sascha Hauer
2011-11-21 10:05 ` Juergen Beisert
2011-11-21 11:30 ` Juergen Beisert
2011-11-16 9:24 ` [PATCH 09/13] Use generic block layer to access the drives and do partition parsing Juergen Beisert
2011-11-17 17:55 ` Sascha Hauer
2011-11-16 9:24 ` [PATCH 10/13] Remove 'disk_drive.c' as it is now replaced by generic partition handling Juergen Beisert
2011-11-16 9:24 ` [PATCH 11/13] ATA/DISK: Remove the now unused header <ata.h> Juergen Beisert
2011-11-16 9:24 ` [PATCH 12/13] ATA Disk Support: Add support for native ATA type drives Juergen Beisert
2011-11-17 20:46 ` Sascha Hauer
2011-11-24 11:28 ` Juergen Beisert [this message]
2011-11-16 9:24 ` [PATCH 13/13] Add driver for IDE like interfaces Juergen Beisert
2011-11-22 8:29 [PATCHv2] Rework of handling disk like media Juergen Beisert
2011-11-22 8:29 ` [PATCH 12/13] ATA Disk Support: Add support for native ATA type drives Juergen Beisert
2011-11-24 12:43 [PATCHv3] Rework of handling disk like media Juergen Beisert
2011-11-24 12:43 ` [PATCH 12/13] ATA Disk Support: Add support for native ATA type drives Juergen Beisert
2011-11-25 14:36 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111241228.51594.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox