mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: *** PROBABLY SPAM *** [PATCH 4/7] at91sam9260_devices: add flag to change ETX{2,3} pincfg on add_device_eth
Date: Mon, 12 Dec 2011 13:50:03 +0100	[thread overview]
Message-ID: <20111212125003.GU27267@pengutronix.de> (raw)
In-Reply-To: <20111209145601.GO23884@game.jcrosoft.org>

On Fri, Dec 09, 2011 at 03:56:01PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:28 Fri 09 Dec     , Michael Grzeschik wrote:
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> >  arch/arm/mach-at91/at91sam9260_devices.c |    9 +++++++--
> please update all soc
> >  1 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
> > index 177f770..be1fdd9 100644
> > --- a/arch/arm/mach-at91/at91sam9260_devices.c
> > +++ b/arch/arm/mach-at91/at91sam9260_devices.c
> > @@ -63,8 +63,13 @@ void at91_add_device_eth(struct at91_ether_platform_data *data)
> >  		at91_set_B_periph(AT91_PIN_PA25, 0);	/* ERX2 */
> >  		at91_set_B_periph(AT91_PIN_PA26, 0);	/* ERX3 */
> >  		at91_set_B_periph(AT91_PIN_PA27, 0);	/* ERXCK */
> > -		at91_set_B_periph(AT91_PIN_PA23, 0);	/* ETX2 */
> > -		at91_set_B_periph(AT91_PIN_PA24, 0);	/* ETX3 */
> > +		if (data->flags & AT91SAM_ETX2_ETX3_ALTERNATIVE) {
> I really don't like the idea to propagate pin configuration to the drivers
> this show stay at board or soc config level

The same is already done with RMII:

	if (!(data->flags & AT91SAM_ETHER_RMII)) {
		at91_set_B_periph(AT91_PIN_PA28, 0);	/* ECRS */
		at91_set_B_periph(AT91_PIN_PA29, 0);	/* ECOL */
		at91_set_B_periph(AT91_PIN_PA25, 0);	/* ERX2 */
		...


> 
> I prefer to add a new parameter than use a flag use by the driver

-ENOPARSE

A new parameter to what? at91_add_device_eth?
The driver itself does not use this flag.

> please make this more generic alt_config1 as this will what is going to be use
> by the pinctrl on at91

Sorry, don't know what you mean.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-12-12 12:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1323187817-28668-1-git-send-email-m.grzeschik@pengutronix.de>
2011-12-09 11:28 ` [PATCH v2 1/7] storage/usb.c: fix test_unit_ready Michael Grzeschik
2011-12-09 11:28 ` [PATCH v2 2/7] atmel_mci: check for device id we use to address the right slot Michael Grzeschik
2011-12-09 11:28 ` [PATCH 3/7] at91sam9260_devices: properly set slot id Michael Grzeschik
2011-12-09 11:28 ` [PATCH 4/7] at91sam9260_devices: add flag to change ETX{2,3} pincfg on add_device_eth Michael Grzeschik
2011-12-09 14:56   ` *** PROBABLY SPAM *** " Jean-Christophe PLAGNIOL-VILLARD
2011-12-12 12:50     ` Sascha Hauer [this message]
2011-12-09 11:28 ` [PATCH v2 5/7] arm: update mach-types Michael Grzeschik
2011-12-09 11:29 ` [PATCH v2 6/7] platform: add support for aizo dSS11 Michael Grzeschik
2011-12-09 15:01   ` *** PROBABLY SPAM *** " Jean-Christophe PLAGNIOL-VILLARD
2011-12-12 12:52     ` Sascha Hauer
2011-12-09 11:29 ` [PATCH v2 7/7] dss11: add defconfig Michael Grzeschik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111212125003.GU27267@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox