From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] defaultenv: use a compressed version when embedded in barebox
Date: Wed, 14 Dec 2011 21:01:37 +0100 [thread overview]
Message-ID: <20111214200137.GK27267@pengutronix.de> (raw)
In-Reply-To: <1323884841-21920-1-git-send-email-plagnioj@jcrosoft.com>
On Wed, Dec 14, 2011 at 06:47:21PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> with using gzip and the default env we can save 5.2KiB (5,352 bytes)
>
> tested on sam9g20ek
> before
> -rwxr-xr-x 1 root root 265748 Dec 14 00:42 barebox.bin
> after
> -rwxr-xr-x 1 root root 260396 Dec 14 00:42 barebox.bin
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> v2:
>
> fix the comment
Appearently you haven't read my mail. So to repeat myself:
> zlib is bigger than the uncompressed defaultenv.
This means that this step is only worth doing when zlib is selected
anyway. Otherwise you end up with 5Kb more: 10Kb zlib binary space + 3Kb
compressed env is bigger than 8Kb uncompressed defaultenv.
So my suggestion was:
> How about a
> config DEFAULT_ENVIRONMENT_COMPRESSED
> default y if ZLIB
> instead?
>
> -include/generated/barebox_default_env.h: barebox_default_env
> +barebox_default_env.gz: barebox_default_env FORCE
And also I asked:
> Do we need this FORCE? It triggers a new build everytime even when
> nothing has changed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-12-14 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 17:47 Jean-Christophe PLAGNIOL-VILLARD
2011-12-14 19:10 ` Eric Bénard
2011-12-15 13:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-14 20:01 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214200137.GK27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox