From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <a.aring@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] omap_hsmmc: setup mmc voltage on twl6030
Date: Sat, 17 Dec 2011 15:32:01 +0100 [thread overview]
Message-ID: <20111217143201.GY27267@pengutronix.de> (raw)
In-Reply-To: <1323939509-10174-4-git-send-email-a.aring@phytec.de>
On Thu, Dec 15, 2011 at 09:58:28AM +0100, Alexander Aring wrote:
> Support the setup of the mmc voltage, when booting OMAP4 with twl6030
> from nand.
>
>
> +config MCI_OMAP_TWL6030_FIX
> + bool "OMAP HSMMC TWL6030 FIX"
> + depends on I2C_TWLCORE && MCI_OMAP_HSMMC && ARCH_OMAP4
> + help
> + Enable TWL6030 support for mci device. OMAP4 Bootloader doesn't setup
> + mmc voltage. So to setup mmc voltage you need to enable this.
We do not need a config switch for this.
Please instead of putting this into driver code just put all code in
this patch into some function in arch/arm/mach-omap/omap4_twl6030_mmc.c
which you then call from your board code. This may not be the cleanest
way to do it but moving it into the mmc driver is not a good solution
either.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-12-17 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1323939509-10174-1-git-send-email-a.aring@phytec.de>
[not found] ` <1323939509-10174-3-git-send-email-a.aring@phytec.de>
2011-12-17 14:19 ` [PATCH 2/4] twl-core: add support for twl6030 Sascha Hauer
[not found] ` <1323939509-10174-4-git-send-email-a.aring@phytec.de>
2011-12-17 14:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217143201.GY27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.aring@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox