From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 7.mo1.mail-out.ovh.net ([87.98.158.110] helo=mo1.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RcGXU-0005Om-Gx for barebox@lists.infradead.org; Sun, 18 Dec 2011 13:12:30 +0000 Received: from mail630.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo1.mail-out.ovh.net (Postfix) with SMTP id 3DECEFFCFB5 for ; Sun, 18 Dec 2011 14:12:52 +0100 (CET) Date: Sun, 18 Dec 2011 14:07:42 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20111218130742.GE7899@game.jcrosoft.org> References: <1323945034-19687-1-git-send-email-s.hauer@pengutronix.de> <1323945034-19687-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1323945034-19687-2-git-send-email-s.hauer@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: *** PROBABLY SPAM *** [PATCH 01/12] oftree: add of_fix_tree() To: Sascha Hauer Cc: barebox@lists.infradead.org HI, what is the impact on the binary size?? Best Regards, J. On 11:30 Thu 15 Dec , Sascha Hauer wrote: > Currently we have of_get_fixed_tree() which assumes that > there is a global variable holding a oftree. This seems > not very flexible, so for now introduce a of_fix_tree() > which takes an fdt_header as argument and walks the > list of registered of fixup functions. > > Signed-off-by: Sascha Hauer > --- > common/oftree.c | 22 +++++++++++++++------- > include/of.h | 1 + > 2 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/common/oftree.c b/common/oftree.c > index 2a2f464..a657d31 100644 > --- a/common/oftree.c > +++ b/common/oftree.c > @@ -293,20 +293,28 @@ int of_register_fixup(int (*fixup)(struct fdt_header *)) > return 0; > } > > -struct fdt_header *of_get_fixed_tree(void) > +int of_fix_tree(struct fdt_header *fdt) > { > struct of_fixup *of_fixup; > int ret; > > - if (!barebox_fdt) > - return NULL; > - > list_for_each_entry(of_fixup, &of_fixup_list, list) { > - ret = of_fixup->fixup(barebox_fdt); > + ret = of_fixup->fixup(fdt); > if (ret) > - return NULL; > + return ret; > } > > - return barebox_fdt; > + return 0; > } > > +struct fdt_header *of_get_fixed_tree(void) > +{ > + int ret; > + > + if (!barebox_fdt) > + return NULL; > + ret = of_fix_tree(barebox_fdt); > + if (ret) > + return NULL; > + return barebox_fdt; > +} > diff --git a/include/of.h b/include/of.h > index c2661ef..609b3b5 100644 > --- a/include/of.h > +++ b/include/of.h > @@ -8,6 +8,7 @@ extern struct fdt_header *barebox_fdt; > int fdt_print(struct fdt_header *working_fdt, const char *pathp); > > struct fdt_header *of_get_fixed_tree(void); > +int of_fix_tree(struct fdt_header *fdt); > int of_register_fixup(int (*fixup)(struct fdt_header *)); > > int fdt_find_and_setprop(struct fdt_header *fdt, const char *node, const char *prop, > -- > 1.7.7.3 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox