From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 3/4] serial gadget: enable/disable on request
Date: Wed, 4 Jan 2012 09:57:42 +0100 [thread overview]
Message-ID: <20120104085742.GN5446@pengutronix.de> (raw)
In-Reply-To: <20120104091158.2b2788f8@eb-e6520>
On Wed, Jan 04, 2012 at 09:11:58AM +0100, Eric Bénard wrote:
> Hi Jean-Christophe,
>
> Le Wed, 4 Jan 2012 09:00:43 +0100,
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
>
> > > +/* case 'o':
> > > + mode = 1;
> > > + break;*/
> > ditto
> > > +/*BAREBOX_CMD_HELP_OPT ("-o", "CDC OBEX\n")*/
> > ditto
>
> that's not an error, OBEX is currently present in serial.c but the
> necessary code is not yet in barebox, so I prepared the code for OBEX
> but comented it out everywhere.
Can you then please add a
/* OBEX support is missing in barebox */
/* #define HAVE_OBEX */
and ifdef the code relevant for OBEX? It makes it more clear why
this is commented out.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-04 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 16:59 [PATCH 1/4] fsl_udc: update and fix Eric Bénard
2012-01-03 16:59 ` [PATCH 2/4] dfu: fill bwPollTimeout and better handle detach Eric Bénard
2012-01-04 9:05 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-03 16:59 ` [PATCH 3/4] serial gadget: enable/disable on request Eric Bénard
2012-01-03 20:52 ` [PATCH v2 " Eric Bénard
2012-01-04 8:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-04 8:11 ` Eric Bénard
2012-01-04 8:57 ` Sascha Hauer [this message]
2012-01-04 8:17 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-04 8:31 ` [PATCH v3 " Eric Bénard
2012-01-04 9:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-03 16:59 ` [PATCH 4/4] eukrea_cpuimx35: fix compilation when CONFIG_USB_GADGET is enabled Eric Bénard
2012-01-04 9:03 ` [PATCH 1/4] fsl_udc: update and fix Sascha Hauer
2012-01-04 9:19 ` Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104085742.GN5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox