From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: fat: gen_numname() is only need with FS_FAT_WRITE
Date: Fri, 6 Jan 2012 09:29:18 +0100 [thread overview]
Message-ID: <20120106082918.GB5446@pengutronix.de> (raw)
In-Reply-To: <1325791095-32363-1-git-send-email-w.sang@pengutronix.de>
On Thu, Jan 05, 2012 at 08:18:15PM +0100, Wolfram Sang wrote:
> So, check for that config option, too. This will get rid of the warning:
>
> fs/fat/ff.c:878:13: warning: 'gen_numname' defined but not used
>
> I could have also moved the function further down, but I decided for the
> least intrusive change.
I already posted the same patch.
Sascha
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> fs/fat/ff.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fat/ff.c b/fs/fat/ff.c
> index 3ada867..0087e21 100644
> --- a/fs/fat/ff.c
> +++ b/fs/fat/ff.c
> @@ -874,7 +874,7 @@ void fit_lfn (
> /*
> * Create numbered name
> */
> -#ifdef CONFIG_FS_FAT_LFN
> +#if defined(CONFIG_FS_FAT_LFN) && defined(CONFIG_FS_FAT_WRITE)
> static void gen_numname (
> BYTE *dst, /* Pointer to generated SFN */
> const BYTE *src, /* Pointer to source SFN to be modified */
> --
> 1.7.7.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-06 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 19:18 Wolfram Sang
2012-01-06 8:29 ` Sascha Hauer [this message]
2012-01-06 9:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106082918.GB5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox