Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 09:27 Tue 10 Jan     , Sascha Hauer wrote:
> On Mon, Jan 09, 2012 at 05:33:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:37 Mon 09 Jan     , Sascha Hauer wrote:
> > > On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > >  drivers/mtd/nand/atmel_nand.c |    6 ++++++
> > > >  1 files changed, 6 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > > > index 3213de2..3e00226 100644
> > > > --- a/drivers/mtd/nand/atmel_nand.c
> > > > +++ b/drivers/mtd/nand/atmel_nand.c
> > > > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> > > >  		}
> > > >  	}
> > > >  
> > > > +	if (host->board->on_flash_bbt) {
> > > > +		printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
> > > 
> > > dev_info?
> > I don't really think it suppose to be here
> 
> That's a driver probe function. Why do you think dev_info is not
> suitable here?
the on_flash_bbt is more mtd specific you have nothing to do it the driver

except enable it

so if we put something in dev_info we need to do it in the nand framwork as
it's the same for all the drivers

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox