From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sanjeev Premi <premi@ti.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 2/2] ARM omap: Add CONFIG_SILENT
Date: Thu, 12 Jan 2012 10:28:53 +0100 [thread overview]
Message-ID: <20120112092853.GZ5446@pengutronix.de> (raw)
In-Reply-To: <1326303284-14444-2-git-send-email-premi@ti.com>
On Wed, Jan 11, 2012 at 11:04:44PM +0530, Sanjeev Premi wrote:
> Don't display any verbose message on the console.
We already have pr_info and friends which right now all fall
back to printf. Instead of adding an ifdef for each conditional
printf how about making pr_* configurable? Something like this:
#if (CONFIG_LOGLEVEL > 6)
#define pr_info(fmt, arg...) printf(fmt, ##arg)
#else
#define pr_info(fmt, arg...) do {} while(0)
#endif
#if (CONFIG_LOGLEVEL > 5)
#define pr_notice(fmt, arg...) printf(fmt, ##arg)
#else
#define pr_notice(fmt, arg...) do {} while(0)
#endif
BTW you seem to be very concerned about the codesize in the xloader
environments, which I can understand. How about giving my thumb2 patches
a try?
panda_xload_defconfig:
-rwxr-xr-x 1 sha ptx 41272 Jan 12 10:25 barebox.bin
panda_xload_defconfig in thumb2 mode:
-rwxr-xr-x 1 sha ptx 30348 Jan 12 10:25 barebox.bin
To merge these I'm currently waiting for Jean-Christophes OK on
ARM: move exception vectors away from start of binary
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-12 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 17:34 [RFC 1/2] ARM omap: Add null console Sanjeev Premi
2012-01-11 17:34 ` [RFC 2/2] ARM omap: Add CONFIG_SILENT Sanjeev Premi
2012-01-12 9:28 ` Sascha Hauer [this message]
2012-01-12 10:54 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-12 12:26 ` Premi, Sanjeev
2012-01-12 15:51 ` Premi, Sanjeev
2012-01-13 11:43 ` Sascha Hauer
2012-01-12 9:13 ` [RFC 1/2] ARM omap: Add null console Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112092853.GZ5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox