From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] usb: fix driver name
Date: Mon, 16 Jan 2012 09:35:27 +0100 [thread overview]
Message-ID: <20120116083527.GK5446@pengutronix.de> (raw)
In-Reply-To: <1326552527-8359-1-git-send-email-plagnioj@jcrosoft.com>
On Sat, Jan 14, 2012 at 03:48:47PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> use the usb_driver name
Can you add some explanation to the commit log why this is needed? Which
name is used before the patch and what does it use now?
Sascha
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/usb/core/usb.c | 1 +
> drivers/usb/storage/usb.c | 1 -
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
> index 7039a2c..f10bcad 100644
> --- a/drivers/usb/core/usb.c
> +++ b/drivers/usb/core/usb.c
> @@ -1275,6 +1275,7 @@ static int usb_hub_probe(struct usb_device *dev, int ifnum)
>
> int usb_driver_register(struct usb_driver *drv)
> {
> + drv->driver.name = drv->name;
> drv->driver.bus = &usb_bus_type;
> return register_driver(&drv->driver);
> }
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index 865ba8e..5b8923f 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -632,7 +632,6 @@ static struct usb_driver usb_storage_driver = {
>
> static int __init usb_stor_init(void)
> {
> - usb_storage_driver.name = usb_storage_driver.driver.name;
> return usb_driver_register(&usb_storage_driver);
> }
> device_initcall(usb_stor_init);
> --
> 1.7.7
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-01-16 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 14:48 Jean-Christophe PLAGNIOL-VILLARD
2012-01-16 8:35 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116083527.GK5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox