mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox mailing list <barebox@lists.infradead.org>
Subject: Re: mx35-3stack 124MiByte RAM
Date: Fri, 27 Jan 2012 13:38:32 +0100	[thread overview]
Message-ID: <20120127123832.GG5446@pengutronix.de> (raw)
In-Reply-To: <4F229A11.8020102@pengutronix.de>

On Fri, Jan 27, 2012 at 01:35:29PM +0100, Marc Kleine-Budde wrote:
> >  
> > -	register_device(&sdram_dev);
> > +	sdram_dev = add_mem_device("ram0", IMX_SDRAM_CS0, 124 * 1024 * 1024,
>                                                           ^^^
> 
> What happened to the upper 4 MiByte?

This was changed in a unrelated patch. Probably a type. This is fixed in
-next since:

commit fc3a2cdcabbbd57c5b1aa018368efd1905256dc1
Author: Roman Fietze <roman.fietze@telemotive.de>
Date:   Wed Apr 27 10:38:46 2011 +0200

    ARM i.MX freescale-mx35-3-stack: support 256 MiB RAM
    
    Extend DCD table and low level init routines. Add barebox SDRAM
    device. Also, fix the memory size for bank 0 to 128MB. It was
    accidently changed to 124MB here:
    
    commit f928efa818adfe56a08350569a9b0f3c2fb791d2
    Author: Sascha Hauer <s.hauer@pengutronix.de>
    Date:   Tue Jul 19 09:58:32 2011 +0200
    
        add a add_mem_device function
    
        Add a helper function for boards to register their memory
        devices. This makes the board code smaller and also helps
        getting rid of map_base and struct memory_platform_data.
    
        And switch all of the memory to it
    
    Signed-off-by: Roman Fietze <roman.fietze@telemotive.de>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-01-27 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 12:35 Marc Kleine-Budde
2012-01-27 12:38 ` Sascha Hauer [this message]
2012-01-27 12:39   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120127123832.GG5446@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox