* [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND
@ 2012-02-07 12:01 Robert P. J. Day
2012-02-07 22:36 ` [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND# Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2012-02-07 12:01 UTC (permalink / raw)
To: U-Boot Version 2 (barebox)
Remove what is an apparently valueless Kconfig variable HAS_OMAP_NAND.
A search of the entire source tree shows:
$ grep -r HAS_OMAP_NAND *
arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
arch/arm/mach-omap/Kconfig:config HAS_OMAP_NAND
arch/arm/configs/phycard_a_l1_defconfig:CONFIG_HAS_OMAP_NAND=y
$
where the definition of that variable is simply:
config HAS_OMAP_NAND
bool
so it seems pretty clear it can be removed as nothing is using it.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
compile-tested for beagleboard. beyond that, it looks like a pretty
safe removal.
diff --git a/arch/arm/configs/phycard_a_l1_defconfig b/arch/arm/configs/phycard_a_l1_defconfig
index 95dffbb..64afcc2 100644
--- a/arch/arm/configs/phycard_a_l1_defconfig
+++ b/arch/arm/configs/phycard_a_l1_defconfig
@@ -13,7 +13,6 @@ CONFIG_OMAP3_CLOCK_CONFIG=y
CONFIG_OMAP3_COPY_CLOCK_SRAM=n
CONFIG_OMAP_GPMC=y
CONFIG_MACH_PCAAL1=y
-CONFIG_HAS_OMAP_NAND=y
CONFIG_AEABI=y
CONFIG_CMD_ARM_CPUINFO=y
CONFIG_ARM_EXCEPTIONS=y
diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
index 73125a7..6a5e674 100644
--- a/arch/arm/mach-omap/Kconfig
+++ b/arch/arm/mach-omap/Kconfig
@@ -114,7 +114,6 @@ config MACH_OMAP343xSDP
bool "Texas Instrument's SDP343x"
select MACH_HAS_LOWLEVEL_INIT
select OMAP_CLOCK_ALL
- select HAS_OMAP_NAND
depends on ARCH_OMAP3
help
Say Y here if you are using SDP343x platform
@@ -124,7 +123,6 @@ config MACH_BEAGLE
select MACH_HAS_LOWLEVEL_INIT
select OMAP_CLOCK_ALL
select HAVE_NOSHELL
- select HAS_OMAP_NAND
depends on ARCH_OMAP3
help
Say Y here if you are using Beagle Board
@@ -133,7 +131,6 @@ config MACH_OMAP3EVM
bool "Texas Instrument's OMAP3 EVM"
select MACH_HAS_LOWLEVEL_INIT
select OMAP_CLOCK_ALL
- select HAS_OMAP_NAND
depends on ARCH_OMAP3
help
Say Y here if you are using OMAP3EVM
@@ -158,7 +155,6 @@ config MACH_PCAAL1
bool "Phytec phyCARD-A-L1"
select MACH_HAS_LOWLEVEL_INIT
select OMAP_CLOCK_ALL
- select HAS_OMAP_NAND
help
Say Y here if you are using a phyCARD-A-L1 PCA-A-L1
@@ -190,7 +186,4 @@ config MACH_OMAP_ADVANCED_MUX
Say Y here if you would like to have complete pin muxing to be
done at boot time
-config HAS_OMAP_NAND
- bool
-
endmenu
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND#
2012-02-07 12:01 [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND Robert P. J. Day
@ 2012-02-07 22:36 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-02-07 22:36 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
On Tue, Feb 07, 2012 at 07:01:04AM -0500, Robert P. J. Day wrote:
>
> Remove what is an apparently valueless Kconfig variable HAS_OMAP_NAND.
> A search of the entire source tree shows:
>
> $ grep -r HAS_OMAP_NAND *
> arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
> arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
> arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
> arch/arm/mach-omap/Kconfig: select HAS_OMAP_NAND
> arch/arm/mach-omap/Kconfig:config HAS_OMAP_NAND
> arch/arm/configs/phycard_a_l1_defconfig:CONFIG_HAS_OMAP_NAND=y
> $
>
> where the definition of that variable is simply:
>
> config HAS_OMAP_NAND
> bool
>
> so it seems pretty clear it can be removed as nothing is using it.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
Applied to master.
Sascha
> ---
>
> compile-tested for beagleboard. beyond that, it looks like a pretty
> safe removal.
>
> diff --git a/arch/arm/configs/phycard_a_l1_defconfig b/arch/arm/configs/phycard_a_l1_defconfig
> index 95dffbb..64afcc2 100644
> --- a/arch/arm/configs/phycard_a_l1_defconfig
> +++ b/arch/arm/configs/phycard_a_l1_defconfig
> @@ -13,7 +13,6 @@ CONFIG_OMAP3_CLOCK_CONFIG=y
> CONFIG_OMAP3_COPY_CLOCK_SRAM=n
> CONFIG_OMAP_GPMC=y
> CONFIG_MACH_PCAAL1=y
> -CONFIG_HAS_OMAP_NAND=y
> CONFIG_AEABI=y
> CONFIG_CMD_ARM_CPUINFO=y
> CONFIG_ARM_EXCEPTIONS=y
> diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
> index 73125a7..6a5e674 100644
> --- a/arch/arm/mach-omap/Kconfig
> +++ b/arch/arm/mach-omap/Kconfig
> @@ -114,7 +114,6 @@ config MACH_OMAP343xSDP
> bool "Texas Instrument's SDP343x"
> select MACH_HAS_LOWLEVEL_INIT
> select OMAP_CLOCK_ALL
> - select HAS_OMAP_NAND
> depends on ARCH_OMAP3
> help
> Say Y here if you are using SDP343x platform
> @@ -124,7 +123,6 @@ config MACH_BEAGLE
> select MACH_HAS_LOWLEVEL_INIT
> select OMAP_CLOCK_ALL
> select HAVE_NOSHELL
> - select HAS_OMAP_NAND
> depends on ARCH_OMAP3
> help
> Say Y here if you are using Beagle Board
> @@ -133,7 +131,6 @@ config MACH_OMAP3EVM
> bool "Texas Instrument's OMAP3 EVM"
> select MACH_HAS_LOWLEVEL_INIT
> select OMAP_CLOCK_ALL
> - select HAS_OMAP_NAND
> depends on ARCH_OMAP3
> help
> Say Y here if you are using OMAP3EVM
> @@ -158,7 +155,6 @@ config MACH_PCAAL1
> bool "Phytec phyCARD-A-L1"
> select MACH_HAS_LOWLEVEL_INIT
> select OMAP_CLOCK_ALL
> - select HAS_OMAP_NAND
> help
> Say Y here if you are using a phyCARD-A-L1 PCA-A-L1
>
> @@ -190,7 +186,4 @@ config MACH_OMAP_ADVANCED_MUX
> Say Y here if you would like to have complete pin muxing to be
> done at boot time
>
> -config HAS_OMAP_NAND
> - bool
> -
> endmenu
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-07 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-07 12:01 [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND Robert P. J. Day
2012-02-07 22:36 ` [PATCH] Remove apparently superfluous Kconfig variable HAS_OMAP_NAND# Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox