From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sanjeev Premi <premi@ti.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] omap: xload: Make error more specific
Date: Fri, 10 Feb 2012 12:36:32 +0100 [thread overview]
Message-ID: <20120210113632.GG3852@pengutronix.de> (raw)
In-Reply-To: <1328812298-1737-1-git-send-email-premi@ti.com>
On Fri, Feb 10, 2012 at 12:01:38AM +0530, Sanjeev Premi wrote:
> Current message indicating that SD card isn't
> mounted is misleading if the card has only one
> partition.
>
> Updated the message to indicate that mounting
> the specific partition failed.
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> arch/arm/mach-omap/xload.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
> index a52a8ba..bf7fd06 100644
> --- a/arch/arm/mach-omap/xload.c
> +++ b/arch/arm/mach-omap/xload.c
> @@ -40,7 +40,7 @@ void *omap_xload_boot_mmc(void)
>
> ret = mount("disk0.0", "fat", "/");
> if (ret) {
> - printf("mounting sd card failed with %d\n", ret);
> + printf("Unable to mount disk0.0 (%d)\n", ret);
Small nitpick: Can we have a const char *diskdev = "disk0.0" and use
it for mount and error message? This makes sure we keep both in sync.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-02-10 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 18:31 Sanjeev Premi
2012-02-10 11:36 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210113632.GG3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox