[PATCH] omap: xload: Make error more specific

[PATCH] omap: xload: Make error more specific

[Sanjeev Premi]

Current message indicating that SD card isn't
mounted is misleading if the card has only one
partition.

Updated the message to indicate that mounting
the specific partition failed.

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 arch/arm/mach-omap/xload.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
index a52a8ba..bf7fd06 100644
--- a/arch/arm/mach-omap/xload.c
+++ b/arch/arm/mach-omap/xload.c
@@ -40,7 +40,7 @@ void *omap_xload_boot_mmc(void)
 
 	ret = mount("disk0.0", "fat", "/");
 	if (ret) {
-		printf("mounting sd card failed with %d\n", ret);
+		printf("Unable to mount disk0.0 (%d)\n", ret);
 		return NULL;
 	}
 
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] omap: xload: Make error more specific

[Sascha Hauer]

On Fri, Feb 10, 2012 at 12:01:38AM +0530, Sanjeev Premi wrote:
> Current message indicating that SD card isn't
> mounted is misleading if the card has only one
> partition.
> 
> Updated the message to indicate that mounting
> the specific partition failed.
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>  arch/arm/mach-omap/xload.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
> index a52a8ba..bf7fd06 100644
> --- a/arch/arm/mach-omap/xload.c
> +++ b/arch/arm/mach-omap/xload.c
> @@ -40,7 +40,7 @@ void *omap_xload_boot_mmc(void)
>  
>  	ret = mount("disk0.0", "fat", "/");
>  	if (ret) {
> -		printf("mounting sd card failed with %d\n", ret);
> +		printf("Unable to mount disk0.0 (%d)\n", ret);

Small nitpick: Can we have a const char *diskdev = "disk0.0" and use
it for mount and error message? This makes sure we keep both in sync.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox