From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [RFC] A first pass at recognizing Pandaboards
Date: Fri, 10 Feb 2012 23:38:56 +0100 [thread overview]
Message-ID: <20120210223856.GL3852@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1202100937130.23570@oneiric>
On Fri, Feb 10, 2012 at 09:39:10AM -0500, Robert P. J. Day wrote:
>
> thoughts on the following patch? it's certainly not the final
> result, but it at least *starts* the process of properly recognizing
> newer pandaboards, using code taking very close to verbatim out of
> u-boot.
>
> it's been compile-tested and appears to still work on all boards it
> did before. i'll do a bit more testing to make sure of that, but is
> there any philosophical objection to the following as a single patch
> submission?
Nope, looks good, except for the whitespace damage between here
> + case MIDR_CORTEX_A9_R2P10:
> + switch (readl(CONTROL_ID_CODE)) {
> + case OMAP4460_CONTROL_ID_CODE_ES1_1:
> + return OMAP4460_ES1_1;
> + break;
> + case OMAP4460_CONTROL_ID_CODE_ES1_0:
> + default:
> + return OMAP4460_ES1_0;
> + break;
> + }
> + break;
> + default:
> + return OMAP4430_SILICON_ID_INVALID;
> + break;
> }
and here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-02-10 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 14:39 Robert P. J. Day
2012-02-10 22:38 ` Sascha Hauer [this message]
2012-02-10 22:40 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210223856.GL3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox