From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Rvz7R-0006ti-E9 for barebox@lists.infradead.org; Fri, 10 Feb 2012 22:39:06 +0000 Date: Fri, 10 Feb 2012 23:38:56 +0100 From: Sascha Hauer Message-ID: <20120210223856.GL3852@pengutronix.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC] A first pass at recognizing Pandaboards To: "Robert P. J. Day" Cc: "U-Boot Version 2 (barebox)" On Fri, Feb 10, 2012 at 09:39:10AM -0500, Robert P. J. Day wrote: > > thoughts on the following patch? it's certainly not the final > result, but it at least *starts* the process of properly recognizing > newer pandaboards, using code taking very close to verbatim out of > u-boot. > > it's been compile-tested and appears to still work on all boards it > did before. i'll do a bit more testing to make sure of that, but is > there any philosophical objection to the following as a single patch > submission? Nope, looks good, except for the whitespace damage between here > + case MIDR_CORTEX_A9_R2P10: > + switch (readl(CONTROL_ID_CODE)) { > + case OMAP4460_CONTROL_ID_CODE_ES1_1: > + return OMAP4460_ES1_1; > + break; > + case OMAP4460_CONTROL_ID_CODE_ES1_0: > + default: > + return OMAP4460_ES1_0; > + break; > + } > + break; > + default: > + return OMAP4430_SILICON_ID_INVALID; > + break; > } and here. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox