[PATCH v2] omap: xload: Make error more specific

[PATCH v2] omap: xload: Make error more specific

[Sanjeev Premi]

Current message indicating that SD card isn't
mounted is misleading if the card has only one
partition.

Updated the message to indicate that mounting
the specific partition failed.

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 Changes since v1:
   Use variable diskdev to ensure that name of device
   used in the mount() and error message continue to
   remain in sync.


 arch/arm/mach-omap/xload.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
index a52a8ba..59f75e2 100644
--- a/arch/arm/mach-omap/xload.c
+++ b/arch/arm/mach-omap/xload.c
@@ -37,10 +37,11 @@ void *omap_xload_boot_mmc(void)
 	int ret;
 	void *buf;
 	int len;
+	const char *diskdev = "disk0.0";
 
-	ret = mount("disk0.0", "fat", "/");
+	ret = mount(diskdev, "fat", "/");
 	if (ret) {
-		printf("mounting sd card failed with %d\n", ret);
+		printf("Unable to mount %s (%d)\n", diskdev, ret);
 		return NULL;
 	}
 
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2] omap: xload: Make error more specific

[Sascha Hauer]

On Mon, Feb 13, 2012 at 03:39:01PM +0530, Sanjeev Premi wrote:
> Current message indicating that SD card isn't
> mounted is misleading if the card has only one
> partition.
> 
> Updated the message to indicate that mounting
> the specific partition failed.
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>  Changes since v1:
>    Use variable diskdev to ensure that name of device
>    used in the mount() and error message continue to
>    remain in sync.

Applied, thanks

Sascha

> 
> 
>  arch/arm/mach-omap/xload.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
> index a52a8ba..59f75e2 100644
> --- a/arch/arm/mach-omap/xload.c
> +++ b/arch/arm/mach-omap/xload.c
> @@ -37,10 +37,11 @@ void *omap_xload_boot_mmc(void)
>  	int ret;
>  	void *buf;
>  	int len;
> +	const char *diskdev = "disk0.0";
>  
> -	ret = mount("disk0.0", "fat", "/");
> +	ret = mount(diskdev, "fat", "/");
>  	if (ret) {
> -		printf("mounting sd card failed with %d\n", ret);
> +		printf("Unable to mount %s (%d)\n", diskdev, ret);
>  		return NULL;
>  	}
>  
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox