mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] mfd: add mc34708 driver
Date: Tue, 21 Feb 2012 15:10:11 +0100	[thread overview]
Message-ID: <20120221141011.GK9343@game.jcrosoft.org> (raw)
In-Reply-To: <20120221142255.547a4e67@eb-e6520>

On 14:22 Tue 21 Feb     , Eric Bénard wrote:
> Le Tue, 21 Feb 2012 14:03:18 +0100,
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> 
> > On 08:03 Tue 21 Feb     , Eric Bénard wrote:
> > > Le Tue, 21 Feb 2012 04:48:35 +0100,
> > > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > > 
> > > > > +static struct mc34708 *mc_dev;
> > > > > +
> > > > > +struct mc34708 *mc34708_get(void)
> > > > > +{
> > > > > +	if (!mc_dev)
> > > > > +		return NULL;
> > > > > +
> > > > > +	return mc_dev;
> > > > > +}
> > > > > +EXPORT_SYMBOL(mc34708_get);
> > > > no please do not export the current as it will not alloe multiple chip on
> > > > board
> > > you can't have more than one of this chip on the board connected to 
> > > the same CPU.
> > except if you have 2 soc on the same board
> > 
> that's why I said "connected to the same CPU".
> If you have 2 SOC, each SOC will have its own PMIC thus it's own
> barebox, thus no problem.
> 
> > here you use it to detect the presence of the device where we can detect it by
> > the presence of the dev file
> 
> in the future we will also use that to write to the PMIC (as done on
> mx35-3stack for example).
I still don't like the idea to export it

You need a proper API to manage the PMIC

so for today no need of this and I doubt the API will need it

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-02-21 14:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21  0:27 [PATCH 1/7] add i2c clock support Eric Bénard
2012-02-21  0:27 ` [PATCH 2/7] mfd: add mc34708 driver Eric Bénard
2012-02-21  3:48   ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-21  7:03     ` Eric Bénard
2012-02-21 13:03       ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-21 13:22         ` Eric Bénard
2012-02-21 14:10           ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-02-21 15:35             ` Eric Bénard
2012-02-21 15:38               ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-21 20:45                 ` Sascha Hauer
2012-02-21 21:09                   ` Marc Reilly
2012-02-21  0:27 ` [PATCH 3/7] i.MX53: add silicn revision functions Eric Bénard
2012-02-22  7:33   ` Sascha Hauer
2012-02-27  8:20     ` [PATCH v2 1/7] add i2c clock support Eric Bénard
2012-02-27  8:20       ` [PATCH v2 2/7] mfd: add mc34708 driver Eric Bénard
2012-02-27  8:20       ` [PATCH v2 3/7] i.MX53: add silicon revision functions Eric Bénard
2012-02-27  8:20       ` [PATCH v2 4/7] i.MX53: enable pull up on I2C0 pins Eric Bénard
2012-02-27  8:20       ` [PATCH v2 5/7] mx53-loco: add i2c support Eric Bénard
2012-02-27  8:20       ` [PATCH v2 6/7] mx53-loco: add board revision support Eric Bénard
2012-02-27 15:40         ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-27 18:58           ` Sascha Hauer
2012-02-27  8:20       ` [PATCH v2 7/7] mx53-loco: update defconfig Eric Bénard
2012-02-27 18:59       ` [PATCH v2 1/7] add i2c clock support Sascha Hauer
2012-02-21  0:27 ` [PATCH 4/7] i.MX53: enable pull up on I2C0 pins Eric Bénard
2012-02-21  0:27 ` [PATCH 5/7] mx53-loco: add i2c support Eric Bénard
2012-02-21  0:27 ` [PATCH 6/7] mx53-loco: add board revision support Eric Bénard
2012-02-21  3:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-21  0:27 ` [PATCH 7/7] mx53-loco: update defconfig Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120221141011.GK9343@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox